-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Generic Surfaces and Generic Linear Surfaces #680
Conversation
Co-authored-by: kevin-alcaniz <[email protected]>
Co-authored-by: kevin-alcaniz <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #680 +/- ##
===========================================
+ Coverage 75.45% 76.02% +0.56%
===========================================
Files 96 99 +3
Lines 10887 11278 +391
===========================================
+ Hits 8215 8574 +359
- Misses 2672 2704 +32 ☔ View full report in Codecov by Sentry. |
Needles to say that this should be done before every commit.
…/RocketPy into enh/free-form-fins
TST: generic surfaces
…/RocketPy into enh/free-form-fins
ENH: Free-Form Fins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't review all the files, but I agree with the changes made to the Rocket and Flight classes
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Description
Added the
GenericSurface
class that takes in coefficients defined by either a function or a .csvAdded the
LinearGenericSurface
class that takes in coefficients derivatives and calculates the total coefficients assuming linearityChanged all
add_surfaces
position
arguments to be 3 dimensionalImproved
Flight
class structure to be indifferent to the type of AeroSurfaceThere is an example simulation in
coeff_testing.ipynb
of calisto using coefficients that were extracted directly from rocketpy's standard model (Barrowman's). It uses the .csvs that have been committed. These .csvs have a LOT of points, this is due to theshepard
interpolation in the Function class, which makes the interpolated values used in the simulation extremely noisy. The files are this big for validation purposes. We should reduce them and create tests with themBreaking change
Remaining Tasks
GenericSurface
orLinearGenericSurface
and use its coefficients for simulation, overwriting any other added aerodynamic surface. The aerodynamic surfaces should still be used for the drawing though. The received generic surface should be positioned in the center of the dry mass of the rocket for the desired behaviorIt would be truly great to get some help on these minor tasks
Future Tasks
GenericSurfaces
andLinearGenericSurfaces
are currently not included in those analysis.Contributors
Special thanks to @kevin-alcaniz and Faraday Rocketry UPV for their contributions!!