ENH: Rocket Axes Definition #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateusStano
added
Enhancement
Gui-FernandesBR
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
This is really nice, I really like the idea of the new page and I know this is going to be crucial for the next steps.
I feel like in the future we should also tell the user that the origin (0, 0, 0) of the flight corresponds to the rocket CDM (center of mass with motor but without propellant), and also better describes the rail length interference in the simulation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #635 +/- ##
===========================================
+ Coverage 75.75% 75.88% +0.13%
===========================================
Files 81 85 +4
Lines 9820 10058 +238
===========================================
+ Hits 7439 7633 +194
- Misses 2381 2425 +44 ☔ View full report in Codecov by Sentry. |
juliomachad0
pushed a commit
that referenced
this pull request
Aug 24, 2024
* ENH: make aerosurface position a Vector * DOC: fixes to addsurfaces refs * DOC: mv rocket.rst to rocket\rocket_usage.rst * ENH: remaining changes for vector position * DOC: aero surfaces docs minor improvements * DOC: create rocket axes description page * DOC: 3d csys correction * ENH: add rail button angular position to initial flight state * REV: revert position to Vector * ENH: consider buttons angular position in initial flight state * DOC: improve docstrings and add references * TST: adapt tests for new buttons angular position * DOC: final additions to flight csys * DEV: changelog * MNT: isort again * DOC: minor fixes * DOC: minor fixes * DOC: minor adjustments --------- Co-authored-by: Gui-FernandesBR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Changes
angular_positionof rail buttons in initial Flight stateBreaking change
Additional information
This is built on top of #634. That PR should be merged first.