-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Pre-calculate attributes in Rocket class #595
ENH: Pre-calculate attributes in Rocket class #595
Conversation
…s from Rocket class
… for more accurate differentiation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #595 +/- ##
===========================================
+ Coverage 73.31% 73.37% +0.05%
===========================================
Files 57 57
Lines 9436 9453 +17
===========================================
+ Hits 6918 6936 +18
+ Misses 2518 2517 -1 ☔ View full report in Codecov by Sentry. |
Is there nothing in the other udots that can be changed to something saved in the rocket class or that can use the new derivative? Might as well go all the way here |
nvm just saw your other PR |
This is a good suggestion. I changed a few attributes in the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for a re-review, just to double check.
@MateusStano could you help me here please?
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
The
u_dot_generalized
method is quite slow...New behavior
Some calculations are now being done directly in the Rocket class, so the
u_dot_generalized
only needs to get it from the Rocket object, instead of calculating it repeatedly.Breaking change
Additional information
This PR requires #594 to be merged.