Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Optional Dependencies Naming in pyproject.toml. #592

Merged
merged 2 commits into from
May 2, 2024

Conversation

phmbressan
Copy link
Collaborator

@phmbressan phmbressan commented May 2, 2024

Pull request type

  • Code changes (bugfix, features)

Checklist

  • CHANGELOG.md has been updated (if relevant)

Current behavior

The installation of optional dependencies env-analysis and àll is not working as expected, yielding the following results:

env-analysis install results
pyproject_env

The same happens with `env_analysis`.

"all" install result
pyproject_all

New behavior

Changing the naming of env_anaysis to the python package normalized env-analysis fixes the first installation issue.

The second was the addition of the all to the optional dependencies.

Breaking change

  • Yes
  • No

Additional information

The recursive syntax to generate the all in the pyproject.toml file is only supported from pip>=21.2 (from 2021). The + symbol from setup.py is not valid in pyproject.toml.

If this is understood as a too strict version compromise, listing all the dependencies is the alternative.

@phmbressan phmbressan added the Bug Something isn't working label May 2, 2024
@phmbressan phmbressan added this to the Release v1.X.0 milestone May 2, 2024
@phmbressan phmbressan self-assigned this May 2, 2024
@phmbressan phmbressan requested a review from a team as a code owner May 2, 2024 20:35
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.03%. Comparing base (1b9e950) to head (c49de29).
Report is 2 commits behind head on develop.

❗ Current head c49de29 differs from pull request most recent head 3264dc9. Consider uploading reports for the commit 3264dc9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #592      +/-   ##
===========================================
+ Coverage    72.97%   73.03%   +0.05%     
===========================================
  Files           57       57              
  Lines         9596     9596              
===========================================
+ Hits          7003     7008       +5     
+ Misses        2593     2588       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phmbressan phmbressan merged commit f487f6b into develop May 2, 2024
7 checks passed
@phmbressan phmbressan deleted the fix/pyproject-opt-dep branch May 2, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants