Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: wrong rocket mass in parachute u dot method #569

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Mar 7, 2024

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

When calculating the parachute forces in the Flight.u_dot_parachute method, the code is using the rocket's mass without the motor's dry mass. It should be using the Rocket.dry_mass value instead.

New behavior

Fixed the bug, updated docs and tests.

Breaking change

  • No (but you should expect some slight change in impact velocity values since the v1.0 was out).

Additional information

  • Quick obs.: Acceptance tests should prevent bugs like this, @lucasfourier @GabrielBarberini !!
  • This bug was captured today by the Faraday team, Spain. Many thanks to their contribution!
    image

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner March 7, 2024 07:24
@Gui-FernandesBR Gui-FernandesBR added Bug Something isn't working Flight Flight Class related features labels Mar 7, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.58%. Comparing base (474eb49) to head (0829a77).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   72.58%   72.58%           
=======================================
  Files          59       59           
  Lines        9576     9576           
=======================================
  Hits         6951     6951           
  Misses       2625     2625           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rocketpy/simulation/flight.py Show resolved Hide resolved
@Gui-FernandesBR Gui-FernandesBR merged commit 31b7a67 into master Mar 8, 2024
11 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/rocket-mass-in-parachute-u-dot branch March 8, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Flight Flight Class related features
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants