ENH: Plotting both power on and off drag curves in a single plot.

[juliomachad0]

Pull request type

• Code changes (bugfix, features)

Checklist

• Docs have been reviewed and added / updated
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest --runslow) have passed locally
• CHANGELOG.md has been updated (if relevant)

Current behavior

Before the changes, the drag curves were plotted separated.

New behavior

Now, with the changes made, there is only a plot with both curves.

Breaking change

• Yes
• No

Additional information

The methods power_on_drag and power_off_drag of the _RocketPlots class were removed.

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (435bd62) 72.32% compared to head (0ccd0b3) 72.31%.

Files	Patch %	Lines
rocketpy/plots/rocket_plots.py	89.47%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #547      +/-   ##
===========================================
- Coverage    72.32%   72.31%   -0.02%     
===========================================
  Files           56       56              
  Lines         9399     9416      +17     
===========================================
+ Hits          6798     6809      +11     
- Misses        2601     2607       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Gui-FernandesBR]

Excellent PR, I went through the PR description and everything was transparent enough.

I'm adding some commentaries with concerns that I have, it would be good to discuss them if needed. Also, please let me know if there's anything you don't understand at a first glance.

Welcome to the Matplotlib School of Engineering!

[Gui-FernandesBR]

LGTM,

Thank you for your first contribution.
It does solve the problem and make our lives better when seeing all those plots.

As a suggestion, mext PR I recommend you to also include a picture of the plot you make so we can have a preview before reviewing it.

[phmbressan]

Great! This is much better to compare the drag curves and adding the transonic region is the icing on the cake.