-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Support for type hints #444
Labels
Docs
Docs and examples related
Enhancement
New feature or request, including adjustments in current codes
Milestone
Comments
Gui-FernandesBR
added
Enhancement
New feature or request, including adjustments in current codes
Docs
Docs and examples related
labels
Oct 30, 2023
10 tasks
We decided to not adopt type hints and annotations in this repository as they would create a need for maintenance that is higher than the benefit. We prefer to exhaustively document our code with doc string, which allows for a good documentation page as well. Can be re-discussed in the future. |
3 tasks
Lucas-Prates
added a commit
that referenced
this issue
May 16, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Jun 25, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Jul 6, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Aug 13, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Aug 18, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Aug 22, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Aug 22, 2024
Fix code style issues with Black BUG: fixing var and std swap mistake in calculations BUG: fixing incorrect print of regressions coefficients on summary table. DOC: adding sensitivity analysis data and simulation notebook. DOC: expanded sensitivity analysis usage notebook ENH: introducing ImportanceModel class for parameter importance analysis MNT: adding imports and renaming analysis folder ENH: implementing plot to ImportanceModel and fixing estimation/import errors ENH: implementing summary method to ImportanceModel MNT: adding optional requirements for ImportanceModel MNT: using optional import tools and adding sensitivity dependency install to setup.py MNT: renaming the term 'importance' to 'sensitivity' in variables, files, and folders MNT: Improving doc and input validation. ENH: implementing function in tools to extract data from MonteCarlo simulation's. MNT: adding json dependency to tools.py MNT: removing type hints for consistency with codebase (#444) MNT: applying review suggestions to sensitivity analysis. BUG: fixing var and std swap mistake in calculations
Gui-FernandesBR
pushed a commit
that referenced
this issue
Aug 25, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Aug 25, 2024
Fix code style issues with Black BUG: fixing var and std swap mistake in calculations BUG: fixing incorrect print of regressions coefficients on summary table. DOC: adding sensitivity analysis data and simulation notebook. DOC: expanded sensitivity analysis usage notebook ENH: introducing ImportanceModel class for parameter importance analysis MNT: adding imports and renaming analysis folder ENH: implementing plot to ImportanceModel and fixing estimation/import errors ENH: implementing summary method to ImportanceModel MNT: adding optional requirements for ImportanceModel MNT: using optional import tools and adding sensitivity dependency install to setup.py MNT: renaming the term 'importance' to 'sensitivity' in variables, files, and folders MNT: Improving doc and input validation. ENH: implementing function in tools to extract data from MonteCarlo simulation's. MNT: adding json dependency to tools.py MNT: removing type hints for consistency with codebase (#444) MNT: applying review suggestions to sensitivity analysis. BUG: fixing var and std swap mistake in calculations
Gui-FernandesBR
pushed a commit
that referenced
this issue
Aug 25, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Aug 25, 2024
Fix code style issues with Black BUG: fixing var and std swap mistake in calculations BUG: fixing incorrect print of regressions coefficients on summary table. DOC: adding sensitivity analysis data and simulation notebook. DOC: expanded sensitivity analysis usage notebook ENH: introducing ImportanceModel class for parameter importance analysis MNT: adding imports and renaming analysis folder ENH: implementing plot to ImportanceModel and fixing estimation/import errors ENH: implementing summary method to ImportanceModel MNT: adding optional requirements for ImportanceModel MNT: using optional import tools and adding sensitivity dependency install to setup.py MNT: renaming the term 'importance' to 'sensitivity' in variables, files, and folders MNT: Improving doc and input validation. ENH: implementing function in tools to extract data from MonteCarlo simulation's. MNT: adding json dependency to tools.py MNT: removing type hints for consistency with codebase (#444) MNT: applying review suggestions to sensitivity analysis. BUG: fixing var and std swap mistake in calculations
Gui-FernandesBR
pushed a commit
that referenced
this issue
Sep 8, 2024
Gui-FernandesBR
pushed a commit
that referenced
this issue
Sep 8, 2024
Fix code style issues with Black BUG: fixing var and std swap mistake in calculations BUG: fixing incorrect print of regressions coefficients on summary table. DOC: adding sensitivity analysis data and simulation notebook. DOC: expanded sensitivity analysis usage notebook ENH: introducing ImportanceModel class for parameter importance analysis MNT: adding imports and renaming analysis folder ENH: implementing plot to ImportanceModel and fixing estimation/import errors ENH: implementing summary method to ImportanceModel MNT: adding optional requirements for ImportanceModel MNT: using optional import tools and adding sensitivity dependency install to setup.py MNT: renaming the term 'importance' to 'sensitivity' in variables, files, and folders MNT: Improving doc and input validation. ENH: implementing function in tools to extract data from MonteCarlo simulation's. MNT: adding json dependency to tools.py MNT: removing type hints for consistency with codebase (#444) MNT: applying review suggestions to sensitivity analysis. BUG: fixing var and std swap mistake in calculations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Docs
Docs and examples related
Enhancement
New feature or request, including adjustments in current codes
Is your feature request related to a problem? Please describe.
Type hints were a great addition of Python 3.5 (https://docs.python.org/3/library/typing.html), and it has been improved in the latest python 3.12 version (https://docs.python.org/3/whatsnew/3.12.html). Here are some points to consider:
Describe the solution you'd like
Additional context
The text was updated successfully, but these errors were encountered: