Skip to content

Commit

Permalink
Merge pull request #598 from nalquas/bug/minor-type-hints
Browse files Browse the repository at this point in the history
BUG: Fix minor type hinting problems
  • Loading branch information
Gui-FernandesBR authored May 13, 2024
2 parents fba6c8c + 4eb9aae commit 693ffac
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Fixed

- BUG: Fix minor type hinting problems [#598](https://github.com/RocketPy-Team/RocketPy/pull/598)
- BUG: Optional Dependencies Naming in pyproject.toml. [#592](https://github.com/RocketPy-Team/RocketPy/pull/592)
- BUG: Swap rocket.total_mass.differentiate for motor.total_mass_flow rate [#585](https://github.com/RocketPy-Team/RocketPy/pull/585)
- BUG: export_eng 'Motor' method would not work for liquid motors. [#559](https://github.com/RocketPy-Team/RocketPy/pull/559)
Expand Down
6 changes: 3 additions & 3 deletions rocketpy/environment/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,9 @@ def __init__(
self,
gravity=None,
date=None,
latitude=0,
longitude=0,
elevation=0,
latitude=0.0,
longitude=0.0,
elevation=0.0,
datum="SIRGAS2000",
timezone="UTC",
max_expected_height=80000.0,
Expand Down
2 changes: 1 addition & 1 deletion rocketpy/motors/solid_motor.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def __init__(
grain_separation,
grains_center_of_mass_position,
center_of_dry_mass_position,
nozzle_position=0,
nozzle_position=0.0,
burn_time=None,
throat_radius=0.01,
reshape_thrust_curve=False,
Expand Down
2 changes: 1 addition & 1 deletion rocketpy/rocket/rocket.py
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ def add_trapezoidal_fins(
tip_chord,
span,
position,
cant_angle=0,
cant_angle=0.0,
sweep_length=None,
sweep_angle=None,
radius=None,
Expand Down
4 changes: 2 additions & 2 deletions rocketpy/simulation/flight.py
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,8 @@ def __init__(
rocket,
environment,
rail_length,
inclination=80,
heading=90,
inclination=80.0,
heading=90.0,
initial_solution=None,
terminate_on_apogee=False,
max_time=600,
Expand Down

0 comments on commit 693ffac

Please sign in to comment.