fix: decode URL-encoded characters in E2E file paths

android/src/main/java/chat/rocket/mobilecrypto/algorithms/AESCrypto.kt

@@ -7,6 +7,8 @@ import java.io.File
 import java.io.FileInputStream
 import java.io.FileOutputStream
 import java.io.InputStream
+import java.net.URLDecoder
+import java.nio.charset.StandardCharsets
 import java.util.UUID
 import javax.crypto.Cipher
 import javax.crypto.spec.GCMParameterSpec
@@ -115,7 +117,7 @@ object AESCrypto {
 
         return if (mode == "decrypt") {
             // Overwrite the input file with the decrypted file
-            val targetPath = if (inputFile.startsWith("file://")) inputFile.substring(7) else inputFile
+            val targetPath = normalizeFilePath(inputFile)
             FileInputStream(outputFileObj).use { inputStream ->
                 FileOutputStream(targetPath).use { fos ->
                     val buffer = ByteArray(BUFFER_SIZE)
@@ -194,10 +196,33 @@ object AESCrypto {
         val uri = Uri.parse(filePath)
 
         return if (uri.scheme == null || uri.scheme == "file") {
-            FileInputStream(uri.path ?: filePath)
+            // Use the decoded path for FileInputStream
+            val normalizedPath = normalizeFilePath(filePath)
+            FileInputStream(normalizedPath)
         } else {
             reactContext.contentResolver.openInputStream(uri)
                 ?: throw IllegalArgumentException("Cannot open input stream for URI: $uri")
         }
     }
+
+    /**
+     * Normalize file path by removing file:// prefix and decoding URL-encoded characters
+     * (e.g., %20 for spaces, %D0%9D for Cyrillic chars)
+     */
+    private fun normalizeFilePath(filePath: String): String {
+        var path = filePath
+
+        // Remove file:// prefix if present
+        if (path.startsWith("file://")) {
+            path = path.substring(7)
+        }
+
+        // Decode URL-encoded characters
+        return try {
+            URLDecoder.decode(path, StandardCharsets.UTF_8.toString())
+        } catch (e: Exception) {
+            // If decoding fails, return the original path
+            path
+        }
+    }
 }

ios/algorithms/AESCrypto.m

@@ -87,7 +87,8 @@ + (nullable NSString *)processFile:(NSString *)filePath operation:(CCOperation)o
     NSData *keyData = [CryptoUtils decodeBase64:keyBase64];
     NSData *ivData = [CryptoUtils decodeBase64:base64Iv];
 
-    NSString *normalizedFilePath = [filePath stringByReplacingOccurrencesOfString:@"file://" withString:@""];
+    NSString *path = [filePath stringByReplacingOccurrencesOfString:@"file://" withString:@""];
+    NSString *normalizedFilePath = [path stringByRemovingPercentEncoding] ?: path;
     NSString *outputFileName = [@"processed_" stringByAppendingString:[normalizedFilePath lastPathComponent]];
     NSString *outputFilePath = [[normalizedFilePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:outputFileName];
 
@@ -149,20 +150,29 @@ + (nullable NSString *)processFile:(NSString *)filePath operation:(CCOperation)o
     [outputStream close];
 
     if (status == kCCSuccess) {
-        NSURL *originalFileURL = [NSURL fileURLWithPath:normalizedFilePath];
-        NSURL *outputFileURL = [NSURL fileURLWithPath:outputFilePath];
+        // For decrypt: return the temp file with sanitized name (to avoid issues with non-ASCII filenames)
+        NSString *originalName = [normalizedFilePath lastPathComponent];
+        NSString *sanitizedName = [originalName stringByReplacingOccurrencesOfString:@"[^a-zA-Z0-9._-]"
+                                                                          withString:@"_"
+                                                                             options:NSRegularExpressionSearch
+                                                                               range:NSMakeRange(0, originalName.length)];
+
+        // Create final file in cache directory with sanitized name
+        NSString *cachePath = NSTemporaryDirectory();
+        NSString *finalPath = [cachePath stringByAppendingPathComponent:[NSString stringWithFormat:@"decrypted_%@", sanitizedName]];
+
         NSError *error = nil;
-        [[NSFileManager defaultManager] replaceItemAtURL:originalFileURL
-                                          withItemAtURL:outputFileURL
-                                         backupItemName:nil
-                                                options:NSFileManagerItemReplacementUsingNewMetadataOnly
-                                       resultingItemURL:nil
-                                                  error:&error];
+        [[NSFileManager defaultManager] removeItemAtPath:finalPath error:nil]; // Remove if exists
+        [[NSFileManager defaultManager] copyItemAtPath:outputFilePath toPath:finalPath error:&error];
+        [[NSFileManager defaultManager] removeItemAtPath:outputFilePath error:nil];
+
         if (error) {
-            NSLog(@"Failed to replace original file: %@", error);
+            NSLog(@"Failed to copy decrypted file: %@", error);
             return nil;
         }
-        return [NSString stringWithFormat:@"file://%@", normalizedFilePath];
+
+        NSLog(@"AESCrypto: Decrypted to temp file: %@", finalPath);
+        return [NSString stringWithFormat:@"file://%@", finalPath];
     } else {
         [[NSFileManager defaultManager] removeItemAtPath:outputFilePath error:nil];
         return nil;

ios/algorithms/FileUtils.m

@@ -220,10 +220,15 @@ + (BOOL)verifyFileIntegrity:(NSString *)filePath expectedChecksum:(NSString *)ex
 }
 
 + (NSString *)normalizeFilePath:(NSString *)filePath {
-    if ([filePath hasPrefix:@"file://"]) {
-        return [filePath substringFromIndex:7];
+    NSString *path = filePath;
+
+    if ([path hasPrefix:@"file://"]) {
+        path = [path substringFromIndex:7];
     }
-    return filePath;
+
+    // Decode URL-encoded characters (e.g., %20 for spaces, %D0%9D for Cyrillic chars)
+    NSString *decodedPath = [path stringByRemovingPercentEncoding];
+    return decodedPath ?: path;
 }
 
 @end

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@rocket.chat/mobile-crypto",
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "Rocket.Chat Mobile Crypto",
   "main": "./lib/module/index.js",
   "module": "./lib/module/index.js",