Update to SDK 3.6.0 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
diegolmello
force-pushed
the
update-lib
branch
from
2982b99 to
849ba16
Compare
diegolmello
commented
Aug 13, 2021
| "react": "16.11.0", | ||
| "react-native": "0.62.2", | ||
| "react-native-jitsi-meet": "^2.1.1" | ||
| "react-native-jitsi-meet": "RocketChat/react-native-jitsi-meet#update-lib" |
Member
Author
There was a problem hiding this comment.
This is weird.
This repo doesn't use bob, so example app doesn't work based on local files and need changes to be pushed to be tested.
We might want to create our own version of it.
| mJitsiMeetViewReference.getJitsiMeetView().getId(), | ||
| "conferenceJoined", | ||
| event); | ||
| @ReactProp(name="options") |
Member
Author
There was a problem hiding this comment.
I took this from https://github.com/sajanthomas01/react-native-jitsi-meet-extended
I removed part of the code to match the way we currently handle on iOS, but we can add later.
Sadly, it creates fragmentation on the way to have a call, but I couldn't find the reason why @ReactMethod call isn't working
|
|
||
| @ReactModule(name = RNJitsiMeetViewManager.REACT_CLASS) | ||
| public class RNJitsiMeetViewManager extends SimpleViewManager<RNJitsiMeetView> implements JitsiMeetViewListener { | ||
| public class RNJitsiMeetViewManager extends SimpleViewManager<RNJitsiMeetView> { |
Member
Author
There was a problem hiding this comment.
Removed deprecated JitsiMeetViewListener and added BrodcastReceiver instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocketChat/Rocket.Chat.ReactNative#3292