Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle livechat message #211

Merged
merged 2 commits into from
Jul 6, 2017
Merged

Conversation

gugahoa
Copy link
Contributor

@gugahoa gugahoa commented May 19, 2017

Hello, everyone,
In this PR there's the basic to receive livechat message without the need to mention the bot.

How to use (for now):

  • Set env var RESPOND_TO_LIVECHAT to true
  • Add the bot as the only agent
  • Send a command (e.g: ping)

Note: It's my first contribution, so any comment is more than welcome! Also, I didn't find any contributing guide, so call me out if I miss something! :^)

@CLAassistant
Copy link

CLAassistant commented May 19, 2017

CLA assistant check
All committers have signed the CLA.

@JigSawFr
Copy link

JigSawFr commented May 26, 2017

Nice, it could be great to be able to assign first bot and have a method to transfer to a real live agent.
The process could be:

  • Guest start a conversation on live chat
  • After sending first message, the bot is assigned to room
  • We want to transfer guest to a real live agent available (you are able to transfer on rocket chat GUI) after asking user or by an automated process.
  • A real agent is transferred.

Good luck for your work :)

@gugahoa gugahoa changed the title [wip] feat: handle livechat message feat: handle livechat message May 31, 2017
@gugahoa
Copy link
Contributor Author

gugahoa commented May 31, 2017

@JigSawFr RocketChat/Rocket.Chat#7136 With this, the first agent can be a bot. :^)
As for transferring, it's the next todo on the list!

@JigSawFr
Copy link

Love it !

@geekgonecrazy
Copy link
Contributor

These changes on their own look good. I know a couple of guys on the team have done some livechat stuff with hubot some how. Going to take a peak and see if we can combine the two.

@geekgonecrazy
Copy link
Contributor

geekgonecrazy commented Jun 8, 2017

Ok I think I got it now.

So the team is actually making use of the hear listener in hubot. The bot is added as an agent in the queue. When its the only one available its assigned to every conversation and is taking all of the messages.

This code seems to then allow the bot to respond to messages that it is directly mentioned. So something like bot what is the weather? would then be handled by the bot.

So for handling livechat messages in general this PR is not required. But... it will allow mentions to be handled by the bot.

Based on this it looks like by default its going to ignore livechat, then when that's on it'll then be able to listen to livechat.

@geekgonecrazy
Copy link
Contributor

@gugahoa could you add this option to the readme and i'll go ahead and merge?

Btw thanks for the contribution!

@geekgonecrazy geekgonecrazy merged commit 9f9e0db into RocketChat:master Jul 6, 2017
@gugahoa gugahoa deleted the livechat branch April 2, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants