Skip to content

chore: add updateConfig method into config service #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricardogarim wants to merge 2 commits into from
Closed

chore: add updateConfig method into config service #289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ed1db
add updateConfig method into config service
ricardogarim Oct 24, 2025
e0b8134
refactor: extract duplicate Zod validation error handling in ConfigSe…
ricardogarim Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 32 additions & 10 deletions packages/federation-sdk/src/services/config.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,24 @@ export class ConfigService {
try {
this.config = AppConfigSchema.parse(values);
} catch (error) {
if (error instanceof z.ZodError) {
this.logger.error({
msg: 'Configuration validation failed:',
err: error,
});
throw new Error(
`Invalid configuration: ${error.errors.map((e) => `${e.path.join('.')}: ${e.message}`).join(', ')}`,
);
}
throw error;
this.handleValidationError(error, 'Configuration validation failed:');
}
}

private handleValidationError(err: unknown, contextMsg?: string): never {
if (err instanceof z.ZodError) {
const errorDetails = err.errors
.map((e) => `${e.path.join('.')}: ${e.message}`)
.join(', ');
this.logger.error({
msg: contextMsg || 'Validation failed',
errors: errorDetails,
});
throw new Error(`Invalid configuration: ${errorDetails}`);
}
throw err;
}

get serverName(): string {
return this.config.serverName;
}
Expand Down Expand Up @@ -156,4 +161,21 @@ export class ConfigService {
const signingKeys = await this.getSigningKey();
return toUnpaddedBase64(signingKeys[0].publicKey);
}

updateConfig(values: AppConfig): void {
try {
const validatedConfig = AppConfigSchema.parse(values);
this.config = validatedConfig;
this.serverKeys = [];
this.logger.debug({
msg: 'Configuration updated',
serverName: validatedConfig.serverName,
});
} catch (error) {
this.handleValidationError(
error,
'Configuration validation failed - check your federation settings',
);
}
}
}