Skip to content

fix: use default power level when one isn't in state #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 2 commits into from
Sep 23, 2025
Merged

fix: use default power level when one isn't in state #206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c6cd1b
use default power level when one isn't in state
debdutdeb Sep 19, 2025
be2b806
..
debdutdeb Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions packages/room/src/state_resolution/definitions/algorithm/v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@

import assert from 'node:assert';
import { PersistentEventBase } from '../../../manager/event-wrapper';
import { PowerLevelEvent } from '../../../manager/power-level-event-wrapper';
import type { EventID, StateMapKey } from '../../../types/_common';
import {} from '../../../types/v3-11';
import {
type EventStore,
getAuthChain,
Expand Down Expand Up @@ -266,11 +266,10 @@ export async function resolveStateV2Plus(
// ^^ non power events, since we should have power events figured out already, i.e. having single resolved power level event, single resolved join rules event, etc.
// we can validate if the rest of the events are "allowed" or not

const powerLevelEvent = partiallyResolvedState.get(
getStateMapKey({ type: 'm.room.power_levels' }),
);

assert(powerLevelEvent, 'power level event should not be null');
const powerLevelEvent =
partiallyResolvedState.get(
getStateMapKey({ type: 'm.room.power_levels' }),
) ?? new PowerLevelEvent().toEventBase();

// mainline ordering essentially sorts the rest of the events
// by their place in the history of the room's power levels.
Expand Down