Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage): Adds wordbreak in Box Component #853

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the typo? other than that is approved

packages/fuselage/src/components/Box/props.stories.mdx Outdated Show resolved Hide resolved
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kodiakhq kodiakhq bot merged commit 21b298c into develop Sep 28, 2022
@kodiakhq kodiakhq bot deleted the feat/box-wordbreak branch September 28, 2022 14:50
gabriellsh added a commit that referenced this pull request Oct 3, 2022
…elage into fix/thumbs_emoji

* 'parser-issues' of github.com:RocketChat/Rocket.Chat.Fuselage:
  fix(message-parser): Update emoticon to output 😨 emoji (#851)
  chore(monorepo): security packages upgrade (#850)
  feat(fuselage): Adds wordbreak in Box Component (#853)
guijun13 pushed a commit that referenced this pull request Oct 4, 2022
* feat(fuselage): Adds wordbreak in Box Component (#853)

* Fixing URL/links parsing issues

* restoring files from base branch

* replacing backstick with single quotes

Co-authored-by: Douglas Fabris <[email protected]>
gabriellsh added a commit that referenced this pull request Oct 5, 2022
* Add first test

* fix: check if is emoticon to preserver colon character

* fix(message-parser): Thumbs emoji becoming phone number (#858)

Co-authored-by: gabriellsh <[email protected]>

* fix(message-parser): Link/URL parser issues (#855)

* feat(fuselage): Adds wordbreak in Box Component (#853)

* Fixing URL/links parsing issues

* restoring files from base branch

* replacing backstick with single quotes

Co-authored-by: Douglas Fabris <[email protected]>

* fixing domainChar accepted chars (#861)

* temporarily removing emphasis support

Co-authored-by: Filipe Marins <[email protected]>
Co-authored-by: Hugo Costa <[email protected]>
Co-authored-by: Douglas Fabris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants