Skip to content

feat: Added download button in the image preview #31994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

abhipatel0211
Copy link
Contributor

@abhipatel0211 abhipatel0211 commented Mar 14, 2024

Proposed changes (including videos or screenshots)

This pull request adds a download button to the image preview feature in Rocketchat. Currently, users are unable to directly download images from the preview. This enhancement aims to improve user experience by providing a convenient and intuitive way to download images directly from the preview modal.

screencast-bpconcjcammlapcogcnnelfmaeghhagj-2024.03.14-18_18_44.webm

Changes Made

  • Added a download button to the image preview modal.
  • Implemented functionality to enable users to download the displayed image with a single click.

Motivation

The addition of a download button aligns with the goal of enhancing usability and improving the overall user experience of Rocketchat. By addressing this feature request, we aim to streamline the process of downloading images, making it more convenient and efficient for users.

Related Issues

Closes RocketChat/feature-requests#883

@abhipatel0211 abhipatel0211 requested a review from a team as a code owner March 14, 2024 13:24
Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: 5206c8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 54.46%. Comparing base (e350be5) to head (5206c8d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   RocketChat/Rocket.Chat#31994      +/-   ##
===========================================
- Coverage    54.53%   54.46%   -0.07%     
===========================================
  Files         2293     2294       +1     
  Lines        50523    50565      +42     
  Branches     10317    10324       +7     
===========================================
- Hits         27552    27541      -11     
- Misses       20472    20524      +52     
- Partials      2499     2500       +1     
Flag Coverage Δ
e2e 53.49% <0.00%> (-0.07%) ⬇️
e2e-api 40.04% <ø> (-0.11%) ⬇️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Download Button to Image Preview
2 participants