Skip to content
This repository was archived by the owner on Mar 17, 2023. It is now read-only.

Conversation

@andweber
Copy link
Contributor

@andweber andweber commented May 4, 2021

Fix in RocketChat/Rocket.Chat#20852 is not active by default.

Additional see: RocketChat/Rocket.Chat#18086

Should be activated manually (proposed here with an update in the docs) or alternativley there is a way of auto-activate - which is at least unknown to me.

Fix in RocketChat/Rocket.Chat#20852 is not active by default. Should be activated manually (proposed here) or alternativley there is a way of auto-activate - which is at least unknown to me.
@CLAassistant
Copy link

CLAassistant commented May 4, 2021

CLA assistant check
All committers have signed the CLA.

@andweber andweber changed the title Update README.md Update snap install instructions in README.md for network-observe plug May 4, 2021
@engelgabriel
Copy link
Member

@geekgonecrazy can. you review this?

@geekgonecrazy
Copy link
Contributor

@andweber not sure I understand the need for this to be recommended as attached. It works with out doing this. What does attaching the plug fix or improve?

@andweber
Copy link
Contributor Author

andweber commented May 6, 2021

well, with current version 3.13.2 (on Ubuntu 20.04 LTS) which includes the fix RocketChat/Rocket.Chat#20852 I still observe the issues mentioned in RocketChat/Rocket.Chat#18086 and RocketChat/Rocket.Chat#14562 (which are by the way the same). Thus the fix seems not yet to work correctly - at least for me and two other mentions in RocketChat/Rocket.Chat#18086.

In the documentation of snaps https://snapcraft.io/docs/network-observe-interface the "network observe" plug is mentioned as "auto-connect: no". I only have a very limited understanding of snap - but as far as I understood the documentation the plug must be manually connected to work.
The plug should only work out of the box in "dev mode" and "classic confinement". Neither is recommended in the rocket chat snap install instruction.

Manually connecting the plug, solves the above issue in version 3.13.2. for me, that's why I assume this has to be done in general and recommended the change.

@geekgonecrazy geekgonecrazy merged commit 7d97bed into RocketChat:master May 22, 2021
@andweber
Copy link
Contributor Author

RocketChat/Rocket.Chat#18086 can be closed as fixed.
(wasn't closed automatically?)

gitbook-com bot pushed a commit that referenced this pull request Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants