[NEW] Broadcast Channels #9950
Merged
[NEW] Broadcast Channels #9950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf336
previously requested changes
Mar 1, 2018
| @@ -219,10 +219,10 @@ Template.channelSettingsEditing.onCreated(function() { | |||
| isToggle: true, | |||
| processing: new ReactiveVar(false), | |||
| canView() { | |||
| return RocketChat.roomTypes.roomTypes[room.t].allowRoomSettingChange(room, RoomSettingsEnum.READ_ONLY); | |||
| return !room.broadcast && RocketChat.roomTypes.roomTypes[room.t].allowRoomSettingChange(room, RoomSettingsEnum.READ_ONLY); | |||
There was a problem hiding this comment.
Can we please create a new room type of broadcast instead of polluting these methods. The room types api was intentionally changed for these style of changes.
There was a problem hiding this comment.
I will take a look. @graywolf336
There was a problem hiding this comment.
@graywolf336 I think for this case we need a new property instead of a new room type, because we thought cool having the ability to chose within a public or private broadcast room, so this way we're using all validations already implemented.
edit: ok looking at the final code I got you meant @graywolf336 😁 it is still a new room property but is using roomTypes methods 👍
sampaiodiego
requested changes
Mar 1, 2018
sampaiodiego
previously approved these changes
Apr 20, 2018
sampaiodiego
dismissed
graywolf336’s stale review
I'll make sure to create an issue to do the changes requested.
sampaiodiego
previously approved these changes
Apr 20, 2018
rodrigok
approved these changes
Apr 21, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
closes #9556