Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] New REST API to mark channel as read #9507

Merged
merged 6 commits into from
Feb 8, 2018
Merged

[NEW] New REST API to mark channel as read #9507

merged 6 commits into from
Feb 8, 2018

Conversation

rafaelks
Copy link
Contributor

@rafaelks rafaelks commented Jan 25, 2018 •
edited
Loading

@RocketChat/core

This PR introduces a new REST API, that allows user to mark any room as read.

Progress

  • API REST
  • Tests (need improvements)
  • Docs

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9507 January 25, 2018 22:26 Inactive
@rafaelks
Copy link
Contributor Author

Documentation PR created: https://github.com/RocketChat/docs/pull/525.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9507 January 25, 2018 22:34 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9507 January 25, 2018 22:36 Inactive
@rafaelks rafaelks changed the title [WIP][NEW] Add a new API that allows to mark any channel as read [NEW] Add a new API that allows to mark any channel as read Jan 25, 2018
@rafaelks
Copy link
Contributor Author

I feel like the tests needs to be improved, checkin with real objects of type channel, group and DM. Can someone help me doing that? Couldn't find any example of that.

@RocketChat RocketChat deleted a comment Jan 25, 2018
@RocketChat RocketChat deleted a comment Jan 25, 2018
@RocketChat RocketChat deleted a comment Jan 25, 2018
@RocketChat RocketChat deleted a comment Jan 25, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9507 January 25, 2018 22:45 Inactive
@rafaelks rafaelks changed the title [NEW] Add a new API that allows to mark any channel as read [NEW] Add a new REST API that allows to mark any channel as read Jan 25, 2018
@rodrigok rodrigok added this to the 0.62.0 milestone Jan 26, 2018
MarcosSpessatto
MarcosSpessatto approved these changes Feb 2, 2018
View reviewed changes
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@rodrigok rodrigok changed the title [NEW] Add a new REST API that allows to mark any channel as read [NEW] New REST API to mark channel as read Feb 8, 2018
@rodrigok rodrigok merged commit 38c16a9 into develop Feb 8, 2018
@rodrigok rodrigok deleted the feature/mark_as_read_rest_api branch February 8, 2018 22:28
@soundstorm soundstorm mentioned this pull request Feb 21, 2018
Closed
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees

@rodrigok rodrigok

Labels
feat: api feat: rest
Projects
None yet
Milestone
0.62.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rafaelks @MarcosSpessatto @rodrigok @engelgabriel