Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Message action quick buttons drops if "new message" divider is being shown #9138

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Fix: Message action quick buttons drops if "new message" divider is being shown #9138

merged 1 commit into from
Dec 15, 2017

Conversation

rodrigok
Copy link
Member

@RocketChat/core

Closes #9129

screen shot 2017-12-14 at 7 11 33 pm

screen shot 2017-12-14 at 7 11 20 pm

screen shot 2017-12-14 at 7 10 53 pm

screen shot 2017-12-14 at 7 10 39 pm

screen shot 2017-12-14 at 7 09 45 pm

screen shot 2017-12-14 at 7 09 32 pm

@rodrigok rodrigok added this to the 0.60.0 milestone Dec 14, 2017
@rodrigok rodrigok requested review from ggazzo and karlprieb December 14, 2017 21:13
karlprieb
karlprieb previously requested changes Dec 14, 2017
View reviewed changes
Copy link
Contributor

@karlprieb karlprieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "fix" increase the size of the message to put the new message line. We must keep the new messages "inside" the message to not change the message height.

@rodrigok rodrigok mentioned this pull request Dec 15, 2017
Closed
@rodrigok rodrigok dismissed karlprieb’s stale review December 15, 2017 00:35

Issue created to fix the message height

@rodrigok rodrigok merged commit 384ea9e into develop Dec 15, 2017
@rodrigok rodrigok deleted the hotfix/9129 branch December 15, 2017 00:35
rodrigok added a commit that referenced this pull request Dec 15, 2017
@rodrigok
Merge pull request #9138 from RocketChat/hotfix/9129
44164a8 
Fix: Message action quick buttons drops if "new message" divider is being shown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@karlprieb karlprieb karlprieb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.60.0
Development

Successfully merging this pull request may close these issues.

Message action quick buttons drops if "new message" divider is being shown
4 participants
@rodrigok @ggazzo @karlprieb @engelgabriel