-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] code to get the updated messages #8857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a rest api that can be added to implement this as well?
@graywolf336 Yes, please. :-) |
@graywolf336 can you review it again? |
as @rafaelks suggested I changed the REST endpoint to |
My suggestion was actually don't return two different types of objects on the same API and don't replicate what we have in |
The api method doesn't conform to the rest of the room and messages apis, there should have been something like @rafaelks said. That's why I didn't review it again, because there were changes needed that were suggested. |
I agree. Will we update the name of the method, or keep the same? @graywolf336 @ggazzo @rodrigok |
@RocketChat/core