Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RocketChat.TabBar #768

Merged
merged 11 commits into from
Sep 11, 2015
Merged

RocketChat.TabBar #768

merged 11 commits into from
Sep 11, 2015

Conversation

marceloschmidt
Copy link
Member

No description provided.

@geekgonecrazy
Copy link
Contributor

Looks good! 👍

engelgabriel added a commit that referenced this pull request Sep 11, 2015
@engelgabriel engelgabriel merged commit bbb81bb into master Sep 11, 2015
@engelgabriel engelgabriel deleted the experiment-tabs branch September 11, 2015 20:05
@Sing-Li
Copy link
Member

Sing-Li commented Sep 12, 2015

On android mobile, large screen phone (samsung note) ... tab bars are difficult to use. It also forces the room messages to become narrow - requiring more scrolling to see messages (smooth scrolling is hardware dependent).

The 'feel' of the app has completely changed. (In my opinion not positive). And at least for now, the mobile user gets no new feature with this, and just penalty.

Can we detect mobile and bring back the old ui for mobile only?

@engelgabriel
Copy link
Member

We will.. not exactly the old... but something more along those lines.

@Morgul
Copy link
Contributor

Morgul commented Sep 12, 2015

What about doing something like this (please, forgive the roughness, I hacked these out in Chrome's dev tools):

That tab bar is hidden behind a ...:

screen shot 2015-09-12 at 12 46 55 pm

Once you hit that, the tabs expand across the top, sliding the channel name and burger out of the way:

screen shot 2015-09-12 at 12 55 31 pm

(The buttons could probably have s similar style to the tabs, I didn't want to bother with recreating that. Additionally, imagine a nice animation sliding everything out of the way.)

Then, the tab buttons work exactly like the current tab bar, except from the top.

@geekgonecrazy
Copy link
Contributor

ah! I think @leefaus actually proposed something just like this.

What about the cases where there are more then can fit across the top?

@Morgul
Copy link
Contributor

Morgul commented Sep 12, 2015

@geekgonecrazy You can scroll the top bar left/right. I've seen several apps do that.

@engelgabriel
Copy link
Member

@Morgul that's aligned with what I have imagined.

@geekgonecrazy
Copy link
Contributor

Would it have tabs when wide and that when small? Or is that too inconsistent?

@Morgul
Copy link
Contributor

Morgul commented Sep 12, 2015

@geekgonecrazy That's what I'm imagining. Nice responsive UI. :)

@Sing-Li
Copy link
Member

Sing-Li commented Sep 13, 2015

@Morgul 👍 swipe left and right to change tabs with underscore selected tab indicator ... certainly a trending Ui concept

@Morgul
Copy link
Contributor

Morgul commented Sep 13, 2015

Yeah, that sounds great. Let's do that. ;)

On Sat, Sep 12, 2015, 10:17 PM SingLi [email protected] wrote:

@Morgul https://github.com/Morgul [image: 👍] swipe left and right to
change tabs with underscore selected tab indicator ... certainly a trending
Ui concept


Reply to this email directly or view it on GitHub
#768 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants