Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Look for livechat visitor IP address on X-Forwarded-For header #7554

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

sampaiodiego
Copy link
Member

@RocketChat/core

Most reverse proxies set the original client IP address on X-Forwarded-For header, so now livechat will be able to get it.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7554 July 24, 2017 11:37 Inactive
@sampaiodiego sampaiodiego changed the title [FIX] Look for visitor IP address on X-Forwarded-For header [FIX] Look for livechat visitor IP address on X-Forwarded-For header Jul 24, 2017
Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if it forces the field name to all lower case? I know a few proxies use uppercase like: X-Forwarded-For

But looks good checks it and falls back to other IP field

@sampaiodiego
Copy link
Member Author

Do you know if it forces the field name to all lower case? I know a few proxies use uppercase like: X-Forwarded-For

@geekgonecrazy yes it does..

@geekgonecrazy
Copy link
Contributor

Perfect 👍 I hoped so 😁

@sampaiodiego sampaiodiego added this to the 0.58.0 milestone Jul 25, 2017
@sampaiodiego sampaiodiego merged commit db9b15d into develop Jul 25, 2017
@rodrigok rodrigok deleted the livechat-get-visitor-ip-address branch July 25, 2017 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants