[FIX] S3 uploads not working for custom URLs #7443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
force-pushed
the
hotfix/allow-s3-custom-endpoint
branch
from
5e08965 to
2a8ea73
Compare
|
@rodrigok Thats awesome, thanks for the fast fix! |
sampaiodiego
approved these changes
Jul 7, 2017
sampaiodiego
changed the title
|
On minio I now get this: |
|
which version @geekgonecrazy ? @rodrigok tested it, but I don't which version he used |
|
@geekgonecrazy I added more 2 options to configure s3, if you are running minio without ssl you need to configure the |
I didn't use SSL. I'll try again with these changes and see if that fixes it 👍 |
|
Switching to v2 and |
rodrigok
added a commit
that referenced
this pull request
Jul 14, 2017
[FIX] S3 uploads not working for custom URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7411