[NEW] Edit user permissions #7309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in Progress
and fix some bugs
karlprieb
reviewed
Jun 25, 2017
| @@ -32,26 +35,50 @@ Template.userEdit.events({ | |||
| 'click .cancel'(e, t) { | |||
| e.stopPropagation(); | |||
| e.preventDefault(); | |||
| return t.cancel(t.find('form')); | |||
| Template.instance().roles.set([]); | |||
There was a problem hiding this comment.
you can use t instead of Template.instance(), right?
| e.preventDefault(); | ||
| let roles = Template.instance().roles.get(); | ||
| roles = roles.filter(el => el !== this.valueOf()); | ||
| Template.instance().roles.set(roles); |
There was a problem hiding this comment.
you can add a second parameter (t) on this event and use that here instead of Template.instance()
| }, | ||
|
|
||
| 'click #randomPassword'(e) { | ||
| e.stopPropagation(); | ||
| e.preventDefault(); | ||
| return $('#password').val(Random.id()); | ||
| $('#password').val(Random.id()); |
instead of template.instance()
rodrigok
approved these changes
Jul 27, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #3656 , #3867 and #1629
This adds the ability to change the user permissions on the user edit tab, also added a better styling to it
TODO: