[FIX] Proxy upload to correct instance

[rodrigok]

@RocketChat/core

[geekgonecrazy]

Curious... Would it be possible to set instance Id when the post happens.
And then proxy the command called here: https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-file-upload/server/lib/FileUpload.js#L282 to the instance that handled the file upload? Instead of proxying the full file upload? It'd be a lot lighter.

I fear what happens if we start proxying full file uploads around multiple instances? Instead of effecting a single instance with an upload we now have two being occupied by the upload.

But... I like this better then uploading to the database and then moving it

[sampaiodiego]

@geekgonecrazy the problem is with the XHR requests, the way it works now the temp file could be split into multiple instances, so no matter where ufsComplete is called it will not be able to grab all temp files.

[geekgonecrazy]

@sampaiodiego yeah that's true.. 👍 it works.

Only request I would have is moving the intercepter out of avatars and into regular upload since it's applying to all uploads. Other then that code looks good.

[geekgonecrazy]

Tested and changes work as expected

[kaji-bikash]

version: '2'

services:
  rocketchat1:
    image: rocketchat/rocket.chat:0.64.2
    restart: unless-stopped
    volumes:
      - ../shared/uploads:/var/snap/rocketchat-server/common/uploads
    environment:
      - INSTANCE_IP=172.17.43.194
      - PORT=3333
      - ROOT_URL=https://rocket.example.com
      - MONGO_URL=mongodb://mongo1:27017/parties
    ports:
      - 3333:3333

  rocketchat2:
    image: rocketchat/rocket.chat:0.64.2
    restart: unless-stopped
    volumes:
      - ../shared/uploads:/var/snap/rocketchat-server/common/uploads
    environment:
      - INSTANCE_IP=172.17.43.194
      - PORT=4444
      - ROOT_URL=https://rocket.example.com
      - MONGO_URL=mongodb://mongo1:27017/parties
    ports:
      - 4444:4444

  rocketchat3:
    image: rocketchat/rocket.chat:0.64.2
    restart: unless-stopped
    volumes:
      - ../shared/uploads:/var/snap/rocketchat-server/common/uploads
    environment:
      - INSTANCE_IP=172.17.43.194
      - PORT=5555
      - ROOT_URL=https://rocket.example.com
      - MONGO_URL=mongodb://mongo1:27017/parties
    ports:
      - 5555:5555

We have 3000+ users with roughly 300-500 users online. All the rocket.chat instances are running in single server and the spec is 16 GB of RAM with 4 cores inside AWS VPC. We have nginx proxing to the rocketchat ports.

We have frequent problems with rocket.chat

• not responding timely,
• message not being sent,
• frozen response,
• uploads are not working.
• .....very slow

We know replica-set would help but anything besides that we could be missing or points that might help our cases.

Much appreciated.

[geekgonecrazy]

Might try posting that in #7524 so it doesn't get lost