Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] postcss parser and cssnext implementation #6982

Merged
merged 37 commits into from
May 23, 2017
Merged

[NEW] postcss parser and cssnext implementation #6982

merged 37 commits into from
May 23, 2017

Conversation

karlprieb
Copy link
Contributor

@karlprieb karlprieb commented May 16, 2017

@RocketChat/core

I realize that our "reset" is not the first css to load on our bundle, now it's fixed, but it generate some style problems that I'm fixing.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6982 May 16, 2017 06:43 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6982 May 16, 2017 07:28 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6982 May 16, 2017 09:09 Inactive
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 10:10 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 10:11 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 12:36 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 12:36 Pending
@karlprieb
Copy link
Contributor Author

@sampaiodiego / @rodrigok I'm still working on little adjustments on base.css, but you can start review if you want :)

@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 17:45 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 17:45 Pending
@karlprieb karlprieb changed the title [WIP] postcss parser and cssnext implementation postcss parser and cssnext implementation May 16, 2017
@karlprieb karlprieb changed the title postcss parser and cssnext implementation [NEW] postcss parser and cssnext implementation May 16, 2017
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 18:18 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 18:19 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 19:10 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 19:11 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 20:29 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 16, 2017 20:30 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 22, 2017 16:48 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 22, 2017 16:48 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 22, 2017 17:07 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 22, 2017 17:08 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 22, 2017 17:17 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 22, 2017 17:18 Pending
@karlprieb
Copy link
Contributor Author

@sampaiodiego Done 👍

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • something added a scroll on the login page (only to google chrome):
    image

  • there are two scroll bars on the admin left panel:
    image

@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 23, 2017 18:49 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 23, 2017 18:49 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 23, 2017 18:54 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 23, 2017 18:54 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 23, 2017 19:36 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 23, 2017 19:37 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 23, 2017 19:59 Pending
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-6982 May 23, 2017 19:59 Pending
@karlprieb
Copy link
Contributor Author

@sampaiodiego it's fixed :)

@karlprieb karlprieb merged commit 9e14767 into develop May 23, 2017
@sampaiodiego sampaiodiego deleted the postcss branch May 25, 2017 20:25
Syirrus pushed a commit to Syirrus/Rocket.Chat that referenced this pull request Jun 5, 2017
…nto clarapy-v4

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (184 commits)
  LingoHub Update 🚀
  unskip sweetalert tests
  fix edit button on firefox
  Fix missing CSS files on production builds
  dependencies upgrade
  remove console.log
  Fix clipboard
  Fix conversion
  Convert Livechat files from Coffeescript to JavaScript
  Fixed typo hmtl -> html
  Add <html> tags to email header and footer
  Fix screensharing check and opens chrome web sorte on error
  [NEW] postcss parser and cssnext implementation (RocketChat#6982)
  remove .only
  better error messages
  changes on the tests names
  Improve tests wip
  ESLint: Prevent duplicated class members
  Fix avatar upload via users.setAvatar REST endpoint
  New screen sharing Chrome extension checking method
  ...

# Conflicts:
#	.meteor/packages
#	.meteor/versions
#	packages/rocketchat-lib/server/lib/PushNotification.js
#	packages/rocketchat-lib/server/models/Users.coffee
#	packages/rocketchat-ui-sidenav/client/sideNav.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants