Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path prefix to sidenav layout #4824

Merged
merged 2 commits into from
Nov 4, 2016
Merged

Add path prefix to sidenav layout #4824

merged 2 commits into from
Nov 4, 2016

Conversation

Huljo
Copy link
Contributor

@Huljo Huljo commented Nov 2, 2016

issue #4798: add path prefix to sidenav layout

@Huljo Huljo changed the title add-prefix-to-layout issue #4798: add path prefix to sidenav layout Nov 2, 2016
engelgabriel
engelgabriel requested changes Nov 2, 2016
View reviewed changes
Copy link
Member

@engelgabriel engelgabriel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the migration.

The setting Layout_Sidenav_Footer is changed by many people directly on the admin panel, so we can't just reset it to the original value.

@engelgabriel engelgabriel added this to the 0.46.0 milestone Nov 2, 2016
@Huljo
Copy link
Contributor Author

Huljo commented Nov 4, 2016

Done

@Huljo Huljo changed the title issue #4798: add path prefix to sidenav layout Add path prefix to sidenav layout Nov 4, 2016
@engelgabriel engelgabriel merged commit f3d5500 into RocketChat:develop Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

@rodrigok rodrigok rodrigok approved these changes

Assignees

@rodrigok rodrigok

Labels
None yet
Projects
None yet
Milestone
0.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Huljo @rodrigok @engelgabriel