Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session as a dependency of rocketchat:lib #4661

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

ziedmahdi
Copy link
Contributor

@RocketChat/core

The package rocketchat:lib is using session in /packages/rocketchat-lib/client/CustomTranslations.js but it's not declared as a direct dependency.

Meteor.autorun(function() {
    // Re apply translations if tap language was changed
    Session.get(TAPi18n._loaded_lang_session_key);
    RocketChat.applyCustomTranslations();
});

This commit will add it as a dependency to let apps include rocketchat:lib with errors.

@rodrigok rodrigok added this to the 0.44.0 milestone Oct 20, 2016
@rodrigok rodrigok merged commit ac8ed14 into RocketChat:develop Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants