chore!: remove dead legacy federation bridge plumbing

.changeset/remove-dead-federation-plumbing.md

@@ -0,0 +1,9 @@
+---
+'@rocket.chat/core-services': major
+'@rocket.chat/rest-typings': major
+'@rocket.chat/core-typings': major
+'@rocket.chat/meteor': major
+'@rocket.chat/i18n': major
+---
+
+Removes dead code left behind by the old Matrix bridge federation: the `Federation`/`FederationEE` service proxies and `IFederationService`/`IFederationServiceEE` interfaces (no service implemented them anymore), the never-implemented `/v1/federation/*` REST endpoint typings (`searchPublicRooms`, `joinExternalPublicRoom`, `listServersByUser`, `addServerByUser`, `removeServerByUser`), the listener-less `federation.userRoleChanged` event, unused federation v1 statistics fields and types, the old two-server federation E2E test suite, and orphaned translation keys.

apps/meteor/client/startup/slashCommands/federation.ts

@@ -1,24 +1,5 @@
 import { slashCommands } from '../../../app/utils/client/slashCommand';
 
-const callback = undefined;
-const result = undefined;
-const providesPreview = false;
-const previewer = undefined;
-const previewCallback = undefined;
-
-slashCommands.add({
-	command: 'federation',
-	callback,
-	options: {
-		description: 'Federation_slash_commands',
-		params: '#command (dm) #user',
-	},
-	result,
-	providesPreview,
-	previewer,
-	previewCallback,
-});
-
 slashCommands.add({
 	command: 'xmpp-join',
 	options: {

apps/meteor/package.json

@@ -52,7 +52,6 @@
 		"stylelint:fix": "stylelint --fix \"app/**/*.css\" \"client/**/*.css\"",
 		"test": "yarn testunit && yarn testapi",
 		"test:e2e": "playwright test",
-		"test:e2e:federation": "playwright test --config=playwright-federation.config.ts",
 		"test:e2e:nyc": "nyc report --reporter=lcovonly",
 		"testapi": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' mocha --config ./.mocharc.api.js",
 		"testapi:livechat": "TS_NODE_COMPILER_OPTIONS='{\"module\": \"commonjs\"}' mocha --config ./.mocharc.api.livechat.js",

apps/meteor/playwright.config.ts

@@ -63,7 +63,6 @@ export default {
 		],
 	].filter(Boolean) as unknown as PlaywrightTestConfig['reporter'],
 	testDir: 'tests/e2e',
-	testIgnore: 'tests/e2e/federation/**',
 	workers: 1,
 	timeout: 60 * 1000,
 	globalTimeout: (process.env.IS_EE === 'true' ? 50 : 40) * 60 * 1000,

apps/meteor/server/meteor-methods/auth/removeUserFromRole.ts

@@ -71,7 +71,5 @@ export const removeUserFromRole = async (userId: string, roleId: string, usernam
 	if (settings.get('UI_DisplayRoles')) {
 		void api.broadcast('user.roleUpdate', event);
 	}
-	void api.broadcast('federation.userRoleChanged', { ...event, givenByUserId: userId });
-
 	return remove;
 };

apps/meteor/server/meteor-methods/rooms/addRoomModerator.ts

@@ -104,8 +104,6 @@ export const addRoomModerator = async (fromUserId: IUser['_id'], rid: IRoom['_id
 		void api.broadcast('user.roleUpdate', event);
 	}
 
-	void api.broadcast('federation.userRoleChanged', { ...event, givenByUserId: fromUserId });
-
 	return true;
 };
 

apps/meteor/server/meteor-methods/rooms/addRoomOwner.ts

@@ -101,7 +101,6 @@ export const addRoomOwner = async (fromUserId: IUser['_id'], rid: IRoom['_id'],
 	if (settings.get('UI_DisplayRoles')) {
 		void api.broadcast('user.roleUpdate', event);
 	}
-	void api.broadcast('federation.userRoleChanged', { ...event, givenByUserId: fromUserId });
 
 	return true;
 };

apps/meteor/server/meteor-methods/rooms/removeRoomModerator.ts

@@ -95,8 +95,6 @@ export const removeRoomModerator = async (fromUserId: IUser['_id'], rid: IRoom['
 	if (settings.get('UI_DisplayRoles')) {
 		void api.broadcast('user.roleUpdate', event);
 	}
-	void api.broadcast('federation.userRoleChanged', { ...event, givenByUserId: fromUserId });
-
 	return true;
 };
 

apps/meteor/server/meteor-methods/rooms/removeRoomOwner.ts

@@ -101,7 +101,6 @@ export const removeRoomOwner = async (fromUserId: string, rid: string, userId: s
 	if (settings.get('UI_DisplayRoles')) {
 		void api.broadcast('user.roleUpdate', event);
 	}
-	void api.broadcast('federation.userRoleChanged', { ...event, givenByUserId: fromUserId });
 	return true;
 };