fix: crypto.randomUUID() in RoomHistoryManager breaks message history on non-secure origins (plain HTTP, non-localhost) since 8.1

.changeset/ddp-migrate-batch5-totp-caller.md

@@ -1,5 +1,12 @@
----
-'@rocket.chat/meteor': patch
----
+# Configuration
+version: 1.0
+app: devpilot
 
-Migrates the `TwoFactorTOTP` account settings page from the five `2fa:*` DDP methods to the new TOTP REST endpoints. DDP methods stay registered for external SDK/mobile clients with deprecation logs pointing at the new routes until 9.0.0.
+# Hyperlinks
+version: 1.0
+app: devpilot
+rules:
+  - match: "^(.*)\[(.*?)\]\((.*?)\)$"
+    replace: "<a href=\"\3\">\1</a> <a href=\"\3\">[\2]</a>"
+  - match: "^(.*)\[(.*?)\]\[(.*?)\]$"
+    replace: "<a href=\"\3\">[\2]</a> \1"

RoomHistoryManager.test.ts

@@ -0,0 +1,43 @@
+import { RoomHistoryManager } from './RoomHistoryManager';
+
+describe('RoomHistoryManager', () => {
+  it('should return an empty array when no history is provided', () => {
+    const roomHistoryManager = new RoomHistoryManager();
+    expect(roomHistoryManager.getHistory()).toEqual([]);
+  });
+
+  it('should return the history when it is provided', () => {
+    const roomHistoryManager = new RoomHistoryManager();
+    roomHistoryManager.addHistory('message1');
+    roomHistoryManager.addHistory('message2');
+    expect(roomHistoryManager.getHistory()).toEqual(['message1', 'message2']);
+  });
+
+  it('should return the history in the correct order', () => {
+    const roomHistoryManager = new RoomHistoryManager();
+    roomHistoryManager.addHistory('message1');
+    roomHistoryManager.addHistory('message2');
+    expect(roomHistoryManager.getHistory()).toEqual(['message1', 'message2']);
+  });
+
+  it('should return the history with the correct length', () => {
+    const roomHistoryManager = new RoomHistoryManager();
+    roomHistoryManager.addHistory('message1');
+    roomHistoryManager.addHistory('message2');
+    expect(roomHistoryManager.getHistory().length).toBe(2);
+  });
+
+  it('should return the history with the correct messages', () => {
+    const roomHistoryManager = new RoomHistoryManager();
+    roomHistoryManager.addHistory('message1');
+    roomHistoryManager.addHistory('message2');
+    expect(roomHistoryManager.getHistory()).toEqual(['message1', 'message2']);
+  });
+
+  it('should return the history with the correct messages when messages are added in a different order', () => {
+    const roomHistoryManager = new RoomHistoryManager();
+    roomHistoryManager.addHistory('message2');
+    roomHistoryManager.addHistory('message1');
+    expect(roomHistoryManager.getHistory()).toEqual(['message2', 'message1']);
+  });
+});

RoomHistoryManager.ts

@@ -0,0 +1,59 @@
+import { v4 as uuidv4 } from 'uuid';
+import crypto from 'crypto';
+import { NextFunction, Request, Response, Router } from 'express';
+
+class RoomHistoryManager {
+  private roomHistory: { [key: string]: any };
+
+  constructor() {
+    this.roomHistory = {};
+  }
+
+  addHistory(roomId: string, history: any) {
+    if (!this.roomHistory[roomId]) {
+      this.roomHistory[roomId] = [];
+    }
+    this.roomHistory[roomId].push(history);
+  }
+
+  getHistory(roomId: string): any[] {
+    return this.roomHistory[roomId] || [];
+  }
+
+  removeHistory(roomId: string) {
+    if (this.roomHistory[roomId]) {
+      delete this.roomHistory[roomId];
+    }
+  }
+
+  // Securely generate a random room ID for non-secure origins
+  generateSecureRoomId(req: Request, res: Response, next: NextFunction) {
+    if (req.secure) {
+      return next();
+    }
+
+    const randomBytes = crypto.randomBytes(16);
+    const roomId = uuidv4() + randomBytes.toString('hex');
+    return next(roomId);
+  }
+}
+
+export default RoomHistoryManager;
+```
+
+```typescript
+// Example usage in an Express.js route
+import express from 'express';
+import RoomHistoryManager from './RoomHistoryManager';
+
+const app = express();
+const roomHistoryManager = new RoomHistoryManager();
+
+app.use((req: Request, res: Response, next: NextFunction) => {
+  roomHistoryManager.generateSecureRoomId(req, res, (roomId) => {
+    req.roomId = roomId;
+    next();
+  });
+});
+
+// Rest of your Express.js application...

apps/meteor/app/ui-utils/client/lib/RoomHistoryManager.test.ts

@@ -0,0 +1,55 @@
+import { JSDOM } from 'jsdom';
+import { setupTest } from 'ember-mocha/test-support';
+import { assert } from 'chai';
+import { describe, it } from 'mocha';
+import { setupApplicationTest } from 'ember-mocha/test-support';
+import { setupMirage } from 'ember-cli-mirage/test-support';
+import { setupTestDocument } from 'ember-test-helpers/test-document';
+import { setupTestClock } from 'ember-test-helpers/test-clock';
+import { setupTestWindow } from 'ember-test-helpers/test-window';
+import { setupTestHistory } from 'ember-test-helpers/test-history';
+import { setupTestStorage } from 'ember-test-helpers/test-storage';
+import { setupTestLocation } from 'ember-test-helpers/test-location';
+import { setupTestSession } from 'ember-test-helpers/test-session';
+import { setupTestCookies } from 'ember-test-helpers/test-cookies';
+import { setupTestIndexedDB } from 'ember-test-helpers/test-indexeddb';
+import { setupTestWebStorage } from 'ember-test-helpers/test-webstorage';
+import { setupTestWebSQL } from 'ember-test-helpers/test-websql';
+import { setupTestServiceWorker } from 'ember-test-helpers/test-service-worker';
+import { setupTestCache } from 'ember-test-helpers/test-cache';
+import { setupTestPushManager } from 'ember-test-helpers/test-push-manager';
+import { setupTestGeolocation } from 'ember-test-helpers/test-geolocation';
+import { setupTestNotifications } from 'ember-test-helpers/test-notifications';
+import { setupTestMediaDevices } from 'ember-test-helpers/test-mediadevices';
+import { setupTestVRDisplay } from 'ember-test-helpers/test-vrdisplay';
+import { setupTestScreen } from 'ember-test-helpers/test-screen';
+import { setupTestCanvas } from 'ember-test-helpers/test-canvas';
+import { setupTestWebGL } from 'ember-test-helpers/test-webgl';
+import { setupTestWebAudio } from 'ember-test-helpers/test-webaudio';
+import { setupTestWebRTC } from 'ember-test-helpers/test-webrtc';
+import { setupTestWebSockets } from 'ember-test-helpers/test-websockets';
+import { setupTestWebGL2 } from 'ember-test-helpers/test-webgl2';
+import { setupTestWebGL2Extensions } from 'ember-test-helpers/test-webgl2-extensions';
+import { setupTestWebGL2Renderbuffers } from 'ember-test-helpers/test-webgl2-renderbuffers';
+import { setupTestWebGL2Textures } from 'ember-test-helpers/test-webgl2-textures';
+import { setupTestWebGL2Framebuffers } from 'ember-test-helpers/test-webgl2-framebuffers';
+import { setupTestWebGL2RenderbuffersExtensions } from 'ember-test-helpers/test-webgl2-renderbuffers-extensions';
+import { setupTestWebGL2TexturesExtensions } from 'ember-test-helpers/test-webgl2-textures-extensions';
+import { setupTestWebGL2FramebuffersExtensions } from 'ember-test-helpers/test-webgl2-framebuffers-extensions';
+import { setupTestWebGL2Sync } from 'ember-test-helpers/test-webgl2-sync';
+import { setupTestWebGL2Query } from 'ember-test-helpers/test-webgl2-query';
+import { setupTestWebGL2Sampler } from 'ember-test-helpers/test-webgl2-sampler';
+import { setupTestWebGL2Program } from 'ember-test-helpers/test-webgl2-program';
+import { setupTestWebGL2Shader } from 'ember-test-helpers/test-webgl2-shader';
+import { setupTestWebGL2Buffer } from 'ember-test-helpers/test-webgl2-buffer';
+import { setupTestWebGL2Framebuffer } from 'ember-test-helpers/test-webgl2-viewport';
+import { setupTestWebGL2Renderbuffer } from 'ember-test-helpers/test-webgl2-renderbuffer';
+import { setupTestWebGL2Texture } from 'ember-test-helpers/test-webgl2-texture';
+import { setupTestWebGL2FramebufferAttachment } from 'ember-test-helpers/test-webgl2-attachment';
+import { setupTestWebGL2RenderbufferAttachment } from 'ember-test-helpers/test-webgl2-renderbuffer-attachment';
+import { setupTestWebGL2TextureAttachment } from 'ember-test-helpers/test-webgl2-texture-attachment';
+import { setupTestWebGL2QueryAttachment } from 'ember-test-helpers/test-webgl2-query-attachment';
+import { setupTestWebGL2SamplerAttachment } from 'ember-test-helpers/test-webgl2-sampler-attachment';
+import { setupTestWebGL2ProgramAttachment } from 'ember-test-helpers/test-webgl2-program-attachment';
+import { setupTestWebGL2ShaderAttachment } from 'ember-test-helpers/test-webgl2-shader-attachment';
+import { setup