Skip to content

regression: Stop audio player on user logout #41603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 3 commits into from
Jul 30, 2026
Merged

regression: Stop audio player on user logout #41603

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f404759
stop audio player on logout
yash-rajpal Jul 28, 2026
50fdd37
use useOnLogout hook
yash-rajpal Jul 28, 2026
19a2374
fix review: unmount media player provider on logout
yash-rajpal Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion apps/meteor/client/providers/MediaPlayerProvider/MediaPlayerProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { useMergedRefs, useStableCallback } from '@rocket.chat/fuselage-hooks';
import { useOnLogout } from '@rocket.chat/ui-contexts';
import type { ReactNode } from 'react';
import { useCallback, useMemo, useRef, useState } from 'react';
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';

import type { MediaPlayerContextValue, PersistentAudioTrack } from './MediaPlayerContext';
import { MediaPlayerContext } from './MediaPlayerContext';
Expand All @@ -27,6 +28,7 @@ const MediaPlayerProvider = ({ children }: MediaPlayerProviderProps) => {
const [currentTime, setCurrentTime] = useState(0);
const [duration, setDuration] = useState(0);
const [playbackRate, setPlaybackRate] = useState<number>(1);
const onLogout = useOnLogout();

const trackRef = useRef<PersistentAudioTrack | null>(null);
trackRef.current = track;
Expand Down Expand Up @@ -100,6 +102,8 @@ const MediaPlayerProvider = ({ children }: MediaPlayerProviderProps) => {
setDuration(0);
});

useEffect(() => onLogout(close), [onLogout, close]);
Comment thread
yash-rajpal marked this conversation as resolved.
Resolved

const isActive = useCallback((id: string) => trackRef.current?.id === id, []);

const value = useMemo<MediaPlayerContextValue>(
Expand Down
Loading