Skip to content

regression: Jump to message not working for audio played from quoted messages #41601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 2 commits into from
Jul 28, 2026
Merged

regression: Jump to message not working for audio played from quoted messages #41601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fc2721
regression: Jump to message not working for audio played from quoted …
KevLehman Jul 28, 2026
2b99385
fix quote source: quotes render via separate Attachments without source
KevLehman Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/meteor/client/components/message/content/attachments/AttachmentsItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const AttachmentsItem = ({ attachment, id, source }: AttachmentsItemProps) => {
}

if (isQuoteAttachment(attachment)) {
return <QuoteAttachment attachment={attachment} />;
return <QuoteAttachment attachment={attachment} source={source} />;
}

return <DefaultAttachment {...(attachment as any)} />;
Expand Down
10 changes: 8 additions & 2 deletions apps/meteor/client/components/message/content/attachments/QuoteAttachment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { useUserPreference } from '@rocket.chat/ui-contexts';
import { useTimeAgo } from '../../../../hooks/useTimeAgo';
import MessageContentBody from '../../MessageContentBody';
import Attachments from '../Attachments';
import type { AudioAttachmentSource } from './file/AudioAttachment';
import AttachmentAuthor from './structure/AttachmentAuthor';
import AttachmentAuthorAvatar from './structure/AttachmentAuthorAvatar';
import AttachmentAuthorName from './structure/AttachmentAuthorName';
Expand Down Expand Up @@ -34,9 +35,10 @@ const quoteStyles = css`

export type QuoteAttachmentProps = {
attachment: MessageQuoteAttachment;
source?: AudioAttachmentSource;
};

export const QuoteAttachment = ({ attachment }: QuoteAttachmentProps) => {
export const QuoteAttachment = ({ attachment, source }: QuoteAttachmentProps) => {
const formatTime = useTimeAgo();
const displayAvatarPreference = useUserPreference<boolean>('displayAvatars');

Expand Down Expand Up @@ -65,7 +67,11 @@ export const QuoteAttachment = ({ attachment }: QuoteAttachmentProps) => {
</AttachmentAuthor>
{attachment.attachments && (
<AttachmentInner>
<Attachments attachments={attachment.attachments} id={attachment.attachments[0]?.title_link} />
<Attachments
attachments={attachment.attachments}
id={attachment.attachments[0]?.title_link}
source={source && { rid: source.rid, mid: source.mid, name: attachment.author_name }}
/>
</AttachmentInner>
)}
{attachment.md ? <MessageContentBody md={attachment.md} /> : attachment.text.substring(attachment.text.indexOf('\n') + 1)}
Expand Down
7 changes: 6 additions & 1 deletion apps/meteor/client/components/message/variants/room/RoomMessageContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,12 @@ const RoomMessageContent = ({ message, unread, all, mention, searchText }: RoomM
</MessageBody>
)}

{!!quotes?.length && <Attachments attachments={quotes} />}
{!!quotes?.length && (
<Attachments
attachments={quotes}
source={{ rid: message.rid, mid: message._id, username: message.u.username, name: message.u.name }}
/>
)}

{!normalizedMessage.blocks?.length && !!normalizedMessage.md?.length && (
<>
Expand Down
7 changes: 6 additions & 1 deletion apps/meteor/client/components/message/variants/thread/ThreadMessageContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,12 @@ const ThreadMessageContent = ({ message }: ThreadMessageContentProps) => {
</MessageBody>
)}

{!!quotes?.length && <Attachments attachments={quotes} />}
{!!quotes?.length && (
<Attachments
attachments={quotes}
source={{ rid: message.rid, mid: message._id, username: message.u.username, name: message.u.name }}
/>
)}

{!normalizedMessage.blocks?.length && !!normalizedMessage.md?.length && (
<>
Expand Down
Loading