Skip to content

test(unit): fix flaky mongo connection test #41526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 1 commit into from
Jul 22, 2026
Merged

test(unit): fix flaky mongo connection test #41526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions packages/ddp-client/__tests__/Connection.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,15 @@ it('should handle reconnecting', async () => {
server,
Comment thread
sampaiodiego marked this conversation as resolved.
jest.advanceTimersByTimeAsync(200),
new Promise((resolve) => connection.once('reconnecting', () => resolve(undefined))),
new Promise((resolve) => connection.once('connection', (data) => resolve(data))),
new Promise((resolve) => {
const handler = (status: string) => {
if (status === 'connected') {
connection.off('connection', handler);
resolve(status);
}
};
connection.on('connection', handler);
}),
);

expect(connection.status).toBe('connected');
Expand Down Expand Up @@ -268,7 +276,15 @@ it('should reset retryCount on a successful connection so subsequent drops can r
server,
jest.advanceTimersByTimeAsync(200),
new Promise((resolve) => connection.once('reconnecting', () => resolve(undefined))),
new Promise((resolve) => connection.once('connection', (data) => resolve(data))),
new Promise((resolve) => {
const handler = (status: string) => {
if (status === 'connected') {
connection.off('connection', handler);
resolve(status);
}
};
connection.on('connection', handler);
}),
);
jest.useRealTimers();
expect(connection.status).toBe('connected');
Expand All @@ -286,7 +302,15 @@ it('should reset retryCount on a successful connection so subsequent drops can r
server,
jest.advanceTimersByTimeAsync(200),
new Promise((resolve) => connection.once('reconnecting', () => resolve(undefined))),
new Promise((resolve) => connection.once('connection', (data) => resolve(data))),
new Promise((resolve) => {
const handler = (status: string) => {
if (status === 'connected') {
connection.off('connection', handler);
resolve(status);
}
};
connection.on('connection', handler);
}),
);
jest.useRealTimers();
expect(connection.status).toBe('connected');
Expand Down Expand Up @@ -316,7 +340,15 @@ it('should ignore a stale ws.onclose that fires after the socket has been replac
server,
jest.advanceTimersByTimeAsync(200),
new Promise((resolve) => connection.once('reconnecting', () => resolve(undefined))),
new Promise((resolve) => connection.once('connection', (data) => resolve(data))),
new Promise((resolve) => {
const handler = (status: string) => {
if (status === 'connected') {
connection.off('connection', handler);
resolve(status);
}
};
connection.on('connection', handler);
}),
);

expect(connection.status).toBe('connected');
Expand Down
Loading