Skip to content

chore(api): migrate channels.ts to typed HTTP methods #41415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 30 commits into from
Jul 29, 2026
Merged

chore(api): migrate channels.ts to typed HTTP methods #41415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
863ba62
chore(api): migrate channels.ts to typed HTTP methods (batch 1/n)
ggazzo Jul 16, 2026
d9d142a
fix(api): preserve errorType in channels error responses
ggazzo Jul 16, 2026
bb7f3c9
docs(api): document typed-router error handling (throws become 500)
ggazzo Jul 16, 2026
0c7e238
chore(api): migrate channels.ts set* endpoints (batch 2)
ggazzo Jul 16, 2026
90af3f4
chore(api): migrate channels.ts role endpoints (batch 3)
ggazzo Jul 16, 2026
7dca3ed
chore(api): migrate channels.ts open/setReadOnly/setAnnouncement (bat…
ggazzo Jul 16, 2026
352041a
chore(api): require room target in channels.set* body schema
ggazzo Jul 16, 2026
34f8657
chore(api): migrate channels.info + channels.list (batch 5)
ggazzo Jul 16, 2026
2f127de
chore(api): migrate channels roles/moderators/delete (batch 6)
ggazzo Jul 16, 2026
76db06f
chore(api): migrate channels close + counters (batch 7)
ggazzo Jul 16, 2026
62cb88d
chore(api): migrate channels members/online (batch 8)
ggazzo Jul 16, 2026
f8df369
chore(api): migrate channels getIntegrations/list.joined/setJoinCode …
ggazzo Jul 16, 2026
e5e60f2
chore(api): migrate channels.messages (batch 10)
ggazzo Jul 16, 2026
55ef8ce
chore(api): migrate channels.anonymousread (batch 11)
ggazzo Jul 16, 2026
ed973c4
chore(api): migrate channels history/getAllUserMentionsByChannel (bat…
ggazzo Jul 16, 2026
329f264
chore(api): migrate channels.create (batch 13)
ggazzo Jul 16, 2026
37d8a6d
chore(api): migrate channels.invite (batch 14)
ggazzo Jul 16, 2026
dc59c57
chore(api): migrate channels files/convertToTeam (batch 15) — channel…
ggazzo Jul 16, 2026
784a83d
fix(api): resolve channels.getIntegrations boot crash (missing IInteg…
ggazzo Jul 17, 2026
614e24e
fix(api): channels response schemas reject real data (members/files/i…
ggazzo Jul 17, 2026
3232493
fix(api): channels.list.joined 400s on ignored roomId query param
ggazzo Jul 17, 2026
cbbd1c9
fix(api): keep [error-code] suffix in channels error messages
ggazzo Jul 17, 2026
1675ed1
fix(api): channels.create extraData + channels.info livechat rooms
ggazzo Jul 18, 2026
f43a0ca
fix(types): IRoom.broadcast is boolean, not literal true
ggazzo Jul 18, 2026
de6e2a0
fix(client): narrow room.broadcast when copying to subscription store
ggazzo Jul 18, 2026
a004396
fix(api): address channels.ts migration review findings
ggazzo Jul 28, 2026
596e008
refactor(api): drop channels errorToFailureArgs; rely on the global A…
ggazzo Jul 28, 2026
b4312d9
refactor(api): drop channels.create error catch; fix error-handling docs
ggazzo Jul 28, 2026
5de17ac
refactor(api): use oneOf for channels.getIntegrations response
ggazzo Jul 28, 2026
5210034
fix(api): restore channels.create unauthorized->forbidden mapping
ggazzo Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/meteor/client/cachedStores/RoomsCachedStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class RoomsCachedStore extends PrivateCachedStore<IRoom> {
cl: room.cl,
topic: room.topic,
announcement: room.announcement,
broadcast: room.broadcast,
broadcast: room.broadcast || undefined,
archived: room.archived,
avatarETag: room.avatarETag,
retention: (room as IRoomWithRetentionPolicy | undefined)?.retention,
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/cachedStores/SubscriptionsCachedStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class SubscriptionsCachedStore extends PrivateCachedStore<SubscriptionWithRoom,
cl: room?.cl,
topic: room?.topic,
announcement: room?.announcement,
broadcast: room?.broadcast,
broadcast: room?.broadcast || undefined,
archived: room?.archived,
avatarETag: room?.avatarETag,
retention: (room as IRoomWithRetentionPolicy | undefined)?.retention,
Expand Down
Loading
Loading