Skip to content

chore: make screen share not rely on bundles from previous negotiations #41369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 2 commits into from
Jul 18, 2026
Merged

chore: make screen share not rely on bundles from previous negotiations #41369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c75e99
fix: rocket.chat not waiting for ice gathering when a new media track…
pierre-lehnen-rc Jul 6, 2026
6ba2f5b
add extra stopped check
pierre-lehnen-rc Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/media-signaling/src/lib/services/webrtc/Processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,21 @@ export class MediaCallWebRTCProcessor implements IWebRTCProcessor {
}

public async waitForIceGathering(): Promise<void> {
if (this.stopped || this.peer.iceGatheringState === 'complete') {
if (this.stopped) {
return;
}

if (this.peer.iceGatheringState === 'complete') {
Comment thread
pierre-lehnen-rc marked this conversation as resolved.
// If the peer state is 'complete', wait long enough for a macrotask to complete to ensure this state is not outdated
await new Promise((resolve) => {
setTimeout(resolve, 1);
});

if (this.stopped || this.peer.iceGatheringState === 'complete') {
return;
}
}
Comment thread
pierre-lehnen-rc marked this conversation as resolved.

this.config.logger?.debug('MediaCallWebRTCProcessor.waitForIceGathering');
await this.initialization;

Expand Down
Loading