Skip to content

regression: Prevent PermissionsTableFilter from growing #41143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 4 commits into from
Jul 2, 2026
Merged

regression: Prevent PermissionsTableFilter from growing #41143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d146e06
fix: wrap `TextInput` with a div
dougfabris Jul 1, 2026
5ee9542
chore: todo
dougfabris Jul 1, 2026
a8186a1
chore: update snapshots
dougfabris Jul 2, 2026
d63ebd9
Merge branch 'release-8.6.0' into regression/permission-table-filter
dougfabris Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion apps/meteor/client/views/admin/permissions/PermissionsTable/PermissionsTableFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ import type { ChangeEvent } from 'react';
import { useState, useEffect } from 'react';
import { useTranslation } from 'react-i18next';

/**
*
* TODO: Replaced this by FilterByText, it has the same render
*/
const PermissionsTableFilter = ({ onChange }: { onChange: (debouncedFilter: string) => void }) => {
const { t } = useTranslation();
const [filter, setFilter] = useState('');
Expand All @@ -17,7 +21,11 @@ const PermissionsTableFilter = ({ onChange }: { onChange: (debouncedFilter: stri
setFilter(value);
});

return <TextInput value={filter} onChange={handleFilter} placeholder={t('Search')} addon={<Icon name='magnifier' size='x20' />} />;
return (
<div>
<TextInput value={filter} onChange={handleFilter} placeholder={t('Search')} addon={<Icon name='magnifier' size='x20' />} />
</div>
);
};

export default PermissionsTableFilter;
80 changes: 42 additions & 38 deletions ...ent/views/admin/permissions/PermissionsTable/__snapshots__/PermissionsTable.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,29 @@ exports[`renders Default without crashing 1`] = `
<div
class="rcx-box rcx-box--full rcx-css-9x4qdd"
>
<label
class="rcx-box rcx-box--full rcx-label rcx-box rcx-box--full rcx-box--animated rcx-input-box__wrapper rcx-css-cnkcl9"
>
<input
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box--type-text rcx-input-box"
placeholder="Search"
size="1"
type="text"
value=""
/>
<span
class="rcx-box rcx-box--full rcx-input-box__addon"
<div>
<label
class="rcx-box rcx-box--full rcx-label rcx-box rcx-box--full rcx-box--animated rcx-input-box__wrapper rcx-css-cnkcl9"
>
<i
aria-hidden="true"
class="rcx-box rcx-box--full rcx-icon--name-magnifier rcx-icon rcx-css-4pvxx3"
<input
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box--type-text rcx-input-box"
placeholder="Search"
size="1"
type="text"
value=""
/>
<span
class="rcx-box rcx-box--full rcx-input-box__addon"
>
</i>
</span>
</label>
<i
aria-hidden="true"
class="rcx-box rcx-box--full rcx-icon--name-magnifier rcx-icon rcx-css-4pvxx3"
>
</i>
</span>
</label>
</div>
<div
class="rcx-box rcx-box--full rcx-css-h9m6k6"
>
Expand Down Expand Up @@ -1191,27 +1193,29 @@ exports[`renders Empty without crashing 1`] = `
<div
class="rcx-box rcx-box--full rcx-css-9x4qdd"
>
<label
class="rcx-box rcx-box--full rcx-label rcx-box rcx-box--full rcx-box--animated rcx-input-box__wrapper rcx-css-cnkcl9"
>
<input
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box--type-text rcx-input-box"
placeholder="Search"
size="1"
type="text"
value=""
/>
<span
class="rcx-box rcx-box--full rcx-input-box__addon"
<div>
<label
class="rcx-box rcx-box--full rcx-label rcx-box rcx-box--full rcx-box--animated rcx-input-box__wrapper rcx-css-cnkcl9"
>
<i
aria-hidden="true"
class="rcx-box rcx-box--full rcx-icon--name-magnifier rcx-icon rcx-css-4pvxx3"
<input
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box--type-text rcx-input-box"
placeholder="Search"
size="1"
type="text"
value=""
/>
<span
class="rcx-box rcx-box--full rcx-input-box__addon"
>
</i>
</span>
</label>
<i
aria-hidden="true"
class="rcx-box rcx-box--full rcx-icon--name-magnifier rcx-icon rcx-css-4pvxx3"
>
</i>
</span>
</label>
</div>
<div
class="rcx-box rcx-box--full rcx-css-1wg1u9h"
>
Expand Down
Loading