Skip to content

regression: DM sidebar tooltip shows empty while presence loads #41107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 2 commits into from
Jul 1, 2026
Merged

regression: DM sidebar tooltip shows empty while presence loads #41107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
776616b
fix: DM sidebar tooltip shows empty while presence loads
ricardogarim Jun 29, 2026
196b9d1
fix: use Skeleton in user status tooltip loading state
ricardogarim Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions apps/meteor/client/hooks/useUserStatusTooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,23 @@
import { useTooltipClose, useTooltipOpen, useUserPresence } from '@rocket.chat/ui-contexts';
import { Skeleton } from '@rocket.chat/fuselage';
import { UserPresenceContext, useTooltipClose, useTooltipOpen, useUserPresence } from '@rocket.chat/ui-contexts';
import type { MouseEvent } from 'react';
import { useCallback, useMemo } from 'react';
import { useCallback, useContext, useMemo } from 'react';

import { UserStatusText } from '../components/UserStatusText';

export function useUserStatusTooltip(uid: string | undefined, title?: string) {
const UserStatusTooltipContent = ({ uid }: { uid: string }) => {
const presence = useUserPresence(uid);

if (!presence) {
return <Skeleton width='x200' variant='text' backgroundColor='surface-light' />;
}

return <UserStatusText status={presence.status} statusText={presence.statusText} statusExpiresAt={presence.statusExpiresAt} />;
};

export function useUserStatusTooltip(uid: string | undefined, title?: string) {
const userPresence = useContext(UserPresenceContext);

const openTooltip = useTooltipOpen();
const closeTooltip = useTooltipClose();

Expand All @@ -19,11 +30,13 @@ export function useUserStatusTooltip(uid: string | undefined, title?: string) {
}

openTooltip(
<UserStatusText status={presence?.status} statusText={presence?.statusText} statusExpiresAt={presence?.statusExpiresAt} />,
<UserPresenceContext.Provider value={userPresence}>
Comment thread
dougfabris marked this conversation as resolved.
<UserStatusTooltipContent uid={uid} />
</UserPresenceContext.Provider>,
target,
);
},
[uid, openTooltip, presence, title],
[uid, openTooltip, title, userPresence],
);

return useMemo(() => ({ 'data-tooltip': '', onMouseEnter, 'onMouseLeave': closeTooltip }), [onMouseEnter, closeTooltip]);
Expand Down
Loading