Skip to content

fix: add job-level lock to prevent redundant cross-instance reads in …fix: Add job-level lock to prevent redundant cross-instance reads in Presence service #40987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZunedKhan07 wants to merge 3 commits into from
Closed

fix: add job-level lock to prevent redundant cross-instance reads in …fix: Add job-level lock to prevent redundant cross-instance reads in Presence service #40987

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52fc22b
fix: add job-level lock to prevent redundant cross-instance reads in …
ZunedKhan07 Jun 17, 2026
6b5acf8
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
ZunedKhan07 Jul 19, 2026
862978c
fix: presence cross instance reads lock
ZunedKhan07 Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ee/packages/presence/src/Presence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,17 @@ export class Presence extends ServiceClass implements IPresence {
override async started(): Promise<void> {
this.reaper.start();
this.lostConTimeout = setTimeout(async () => {
const affectedUsers = await this.removeLostConnections();
return affectedUsers.forEach((uid) => this.updateUserPresence(uid));
const lock = await this.api?.lock('presence.removeLostConnections', 5000);
if (!lock) {
return;
}

try {
const affectedUsers = await this.removeLostConnections();
affectedUsers.forEach((uid) => this.updateUserPresence(uid));
} finally {
await lock.release();
}
}, 10000);

try {
Expand Down