Skip to content

chore(deps): bump xmldom and related deps #40428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julio-rocketchat merged 1 commit into from
May 6, 2026
Merged

chore(deps): bump xmldom and related deps #40428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/update-version-durability/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"colors": "^1.4.0",
"diff": "^5.1.0",
"semver": "^7.5.4",
"@xmldom/xmldom": "^0.8.10"
"@xmldom/xmldom": "^0.8.13"
}
}
6 changes: 4 additions & 2 deletions apps/meteor/app/meteor-accounts-saml/server/lib/parsers/Response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,9 @@ export class ResponseParser {
let newXml = null;

if (typeof encAssertion !== 'undefined') {
const options = { key: this.serviceProviderOptions.privateKey };
// disallowDecryptionWithInsecureAlgorithm defaults to true in xml-encryption v4, but AES-CBC/3DES
// are still widely used by SAML IdPs in practice, so we keep the pre-v4 behaviour here.
const options = { key: this.serviceProviderOptions.privateKey, disallowDecryptionWithInsecureAlgorithm: false };
const encData = encAssertion.getElementsByTagNameNS('*', 'EncryptedData')[0];
xmlenc.decrypt(encData, options, (err, result) => {
if (err) {
Expand Down Expand Up @@ -350,7 +352,7 @@ export class ResponseParser {
const encSubject = assertion.getElementsByTagNameNS('urn:oasis:names:tc:SAML:2.0:assertion', 'EncryptedID')[0];

if (typeof encSubject !== 'undefined') {
const options = { key: this.serviceProviderOptions.privateKey };
const options = { key: this.serviceProviderOptions.privateKey, disallowDecryptionWithInsecureAlgorithm: false };
xmlenc.decrypt(encSubject.getElementsByTagNameNS('*', 'EncryptedData')[0], options, (err, result) => {
if (err) {
SAMLUtils.error({ err });
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@
"universal-perf-hooks": "^1.0.1",
"webdav": "^4.11.5",
"xml-crypto": "~3.2.1",
"xml-encryption": "~3.1.0",
"xml-encryption": "~4.0.0",
"xml2js": "~0.6.2",
"yaqrcode": "^0.2.1",
"zod": "~4.3.6",
Expand Down
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@
"lodash": "4.17.21",
"minimist": "1.2.6",
"mongodb": "6.10.0",
"underscore": "1.13.7"
"underscore": "1.13.7",
"xml-crypto/@xmldom/xmldom": "0.8.13",
"xml-encryption/@xmldom/xmldom": "0.8.13"
},
"dependencies": {
"@types/stream-buffers": "^3.0.8",
Expand Down
Loading
Loading