Skip to content

fix: Use multiselectfiltered instead of multiselect on abac room sidebar #40423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 2 commits into from
May 7, 2026
Merged

fix: Use multiselectfiltered instead of multiselect on abac room sidebar #40423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
399b4ee
multiselectfiltered for values
KevLehman May 6, 2026
92d1fce
Create lovely-laws-wait.md
KevLehman May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lovely-laws-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Allows users to search for attribute values when assigning them to rooms
4 changes: 2 additions & 2 deletions apps/meteor/client/views/admin/ABAC/ABACRoomsTab/RoomFormAttributeField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { SelectOption } from '@rocket.chat/fuselage';
import { Box, Button, FieldError, FieldRow, MultiSelect, SelectFiltered } from '@rocket.chat/fuselage';
import { Box, Button, FieldError, FieldRow, MultiSelectFiltered, SelectFiltered } from '@rocket.chat/fuselage';
import { useCallback, useMemo } from 'react';
import { useController, useFormContext } from 'react-hook-form';
import { useTranslation } from 'react-i18next';
Expand Down Expand Up @@ -83,7 +83,7 @@ const RoomFormAttributeField = ({ labelId, onRemove, index, attributeList, requi
</FieldError>
)}
<FieldRow>
<MultiSelect
<MultiSelectFiltered
required={required}
aria-required={required}
aria-labelledby={labelId}
Expand Down
11 changes: 5 additions & 6 deletions ...r/client/views/admin/ABAC/ABACRoomsTab/__snapshots__/RoomFormAttributeField.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,17 @@ exports[`RoomFormAttributeField renders Default without crashing 1`] = `
<div
class="rcx-box rcx-box--full rcx-css-w398ts"
>
<button
<input
aria-expanded="false"
aria-haspopup="listbox"
aria-invalid="false"
aria-required="false"
class="rcx-box rcx-box--full rcx-input-box--undecorated rcx-select__focus rcx-css-trljwa rcx-css-3fq6z9"
class="rcx-box rcx-box--full rcx-box--animated rcx-input-box--undecorated rcx-input-box rcx-css-trljwa rcx-css-pqpp8q"
name="attributes.0.values"
placeholder="ABAC_Select_Attribute_Values"
role="combobox"
type="button"
>
ABAC_Select_Attribute_Values
</button>
value=""
/>
</div>
</div>
<div
Expand Down
Loading