Skip to content

test: channel-management tests running before home page is ready #40028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 2 commits into from
Apr 2, 2026
Merged

test: channel-management tests running before home page is ready #40028

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
495853a
test: fix flaky channel-management tests
jessicaschelly Apr 1, 2026
a425432
Merge branch 'develop' into test/fix-flaky-channel-management
jessicaschelly Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions apps/meteor/tests/e2e/channel-management.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ test.describe.serial('channel-management', () => {
poHomeChannel = new HomeChannel(page);

await page.goto('/home');
await poHomeChannel.waitForHome();
});

test('should navigate on toolbar using arrow keys', async ({ page }) => {
Expand Down Expand Up @@ -57,7 +58,7 @@ test.describe.serial('channel-management', () => {
await expect(poHomeChannel.content.getSystemMessageByText('added user1')).toBeVisible();
});

test('should edit topic of targetChannel', async ({ page }) => {
test('should edit topic of targetChannel', async () => {
await poHomeChannel.navbar.openChat(targetChannel);
await poHomeChannel.roomToolbar.openRoomInfo();
await poHomeChannel.tabs.room.btnEdit.click();
Expand All @@ -67,11 +68,11 @@ test.describe.serial('channel-management', () => {
await poHomeChannel.toastMessage.dismissToast();
await poHomeChannel.roomToolbar.openRoomInfo();

await expect(page.getByRole('dialog', { name: 'Channel info' })).toContainText('hello-topic-edited');
await expect(poHomeChannel.tabs.room.panelChannelInfo).toContainText('hello-topic-edited');
await expect(poHomeChannel.content.getSystemMessageByText('changed room topic to hello-topic-edited')).toBeVisible();
});

test('should edit announcement of targetChannel', async ({ page }) => {
test('should edit announcement of targetChannel', async () => {
await poHomeChannel.navbar.openChat(targetChannel);
await poHomeChannel.roomToolbar.openRoomInfo();
await poHomeChannel.tabs.room.btnEdit.click();
Expand All @@ -80,11 +81,11 @@ test.describe.serial('channel-management', () => {

await poHomeChannel.toastMessage.dismissToast();
await poHomeChannel.roomToolbar.openRoomInfo();
await expect(page.getByRole('dialog', { name: 'Channel info' })).toContainText('hello-announcement-edited');
await expect(poHomeChannel.tabs.room.panelChannelInfo).toContainText('hello-announcement-edited');
await expect(poHomeChannel.content.getSystemMessageByText('changed room announcement to: hello-announcement-edited')).toBeVisible();
});

test('should edit description of targetChannel', async ({ page }) => {
test('should edit description of targetChannel', async () => {
await poHomeChannel.navbar.openChat(targetChannel);
await poHomeChannel.roomToolbar.openRoomInfo();
await poHomeChannel.tabs.room.btnEdit.click();
Expand All @@ -93,7 +94,7 @@ test.describe.serial('channel-management', () => {

await poHomeChannel.toastMessage.dismissToast();
await poHomeChannel.roomToolbar.openRoomInfo();
await expect(page.getByRole('dialog', { name: 'Channel info' })).toContainText('hello-description-edited');
await expect(poHomeChannel.tabs.room.panelChannelInfo).toContainText('hello-description-edited');
await expect(poHomeChannel.content.getSystemMessageByText('changed room description to: hello-description-edited')).toBeVisible();
});

Expand All @@ -105,7 +106,7 @@ test.describe.serial('channel-management', () => {
await poHomeChannel.tabs.room.btnSave.click();

targetChannel = `NAME-EDITED-${targetChannel}`;
await expect(page.locator(`role=main >> role=heading[name="${targetChannel}"]`)).toBeVisible();
await expect(page.getByRole('main').getByRole('heading', { name: targetChannel })).toBeVisible();
await poHomeChannel.navbar.openChat(targetChannel);

await expect(page).toHaveURL(`/channel/${targetChannel}`);
Expand Down
4 changes: 4 additions & 0 deletions apps/meteor/tests/e2e/page-objects/fragments/home-flextab-room.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,4 +131,8 @@ export class HomeFlextabRoom {
await this.checkboxChannels.click();
await this.checkboxDiscussions.click();
}

get panelChannelInfo(): Locator {
return this.page.getByRole('dialog', { name: 'Channel info' });
}
}
Loading