Skip to content

fix(apps): updateStatusText not broadcasting presence.status #39823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dionisio-bot merged 8 commits into from
Mar 25, 2026
Merged

fix(apps): updateStatusText not broadcasting presence.status #39823

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4a290cf
fix: updateStatusText not broadcasting presence.status
dougfabris Mar 23, 2026
01cca4e
small refactor
d-gubert Mar 23, 2026
2331dd2
apply suggestion from ancestral review
d-gubert Mar 23, 2026
35daadc
chore: changeset
dougfabris Mar 23, 2026
261b1d6
test: add update-status-test app and its tests
dougfabris Mar 24, 2026
c8d83ec
test: remove 400 error tests for updateStatusText and updateStatus
dougfabris Mar 24, 2026
97cb2c6
refactor: clarify why the user status can't be checked on tests
d-gubert Mar 24, 2026
34feb50
fix: incorrect validation placement
d-gubert Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions apps/meteor/app/apps/server/bridges/users.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { Random } from '@rocket.chat/random';
import { checkUsernameAvailability } from '../../../lib/server/functions/checkUsernameAvailability';
import { deleteUser } from '../../../lib/server/functions/deleteUser';
import { getUserCreatedByApp } from '../../../lib/server/functions/getUserCreatedByApp';
import { setStatusText } from '../../../lib/server/functions/setStatusText';
import { setUserActiveStatus } from '../../../lib/server/functions/setUserActiveStatus';
import { setUserAvatar } from '../../../lib/server/functions/setUserAvatar';
import { notifyOnUserChange, notifyOnUserChangeById } from '../../../lib/server/lib/notifyListener';
Expand Down Expand Up @@ -131,16 +132,27 @@ export class AppUserBridge extends UserBridge {
return true;
}

const { status } = fields;
delete fields.status;
const { status, statusText, ...updateFields } = fields;

if (status) {
await Presence.setStatus(user.id, status as UserStatus, fields.statusText);
await Presence.setStatus(user.id, status as UserStatus, statusText);
} else if (typeof statusText === 'string') {
await setStatusText(
{
_id: user.id,
username: user.username,
name: user.name,
status: user.status as UserStatus,
roles: user.roles,
statusText: user.statusText,
},
statusText,
);
}

await Users.updateOne({ _id: user.id }, { $set: fields as any });
await Users.updateOne({ _id: user.id }, { $set: updateFields as any });

void notifyOnUserChange({ clientAction: 'updated', id: user.id, diff: fields });
void notifyOnUserChange({ clientAction: 'updated', id: user.id, diff: updateFields });

return true;
}
Expand Down
Loading