chore: migrate presence endpoints to new API pattern

.changeset/refactor-presence-api-chained-pattern.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Migrated `presence.getConnections` and `presence.enableBroadcast` REST API endpoints from legacy `addRoute` pattern to the new chained `.get()`/`.post()` API pattern with typed response schemas.

apps/meteor/app/api/server/v1/presence.ts

@@ -1,27 +1,63 @@
 import { Presence } from '@rocket.chat/core-services';
+import { ajv, validateUnauthorizedErrorResponse, validateForbiddenErrorResponse } from '@rocket.chat/rest-typings';
 
 import { API } from '../api';
 
-API.v1.addRoute(
+API.v1.get(
 	'presence.getConnections',
-	{ authRequired: true, permissionsRequired: ['manage-user-status'] },
 	{
-		async get() {
-			const result = await Presence.getConnectionCount();
-
-			return API.v1.success(result);
+		authRequired: true,
+		permissionsRequired: ['manage-user-status'],
+		response: {
+			200: ajv.compile<{ current: number; max: number }>({
+				type: 'object',
+				properties: {
+					current: { type: 'number' },
+					max: { type: 'number' },
+					success: {
+						type: 'boolean',
+						enum: [true],
+					},
+				},
+				required: ['current', 'max', 'success'],
+				additionalProperties: false,
+			}),
+			401: validateUnauthorizedErrorResponse,
+			403: validateForbiddenErrorResponse,
 		},
 	},
+	async function action() {
+		const result = await Presence.getConnectionCount();
+
+		return API.v1.success(result);
+	},
 );
 
-API.v1.addRoute(
+API.v1.post(
 	'presence.enableBroadcast',
-	{ authRequired: true, permissionsRequired: ['manage-user-status'], twoFactorRequired: true },
 	{
-		async post() {
-			await Presence.toggleBroadcast(true);
-
-			return API.v1.success();
+		authRequired: true,
+		permissionsRequired: ['manage-user-status'],
+		twoFactorRequired: true,
+		response: {
+			200: ajv.compile<void>({
+				type: 'object',
+				properties: {
+					success: {
+						type: 'boolean',
+						enum: [true],
+					},
+				},
+				required: ['success'],
+				additionalProperties: false,
+			}),
+			401: validateUnauthorizedErrorResponse,
+			403: validateForbiddenErrorResponse,
 		},
 	},
+	async function action() {
+		await Presence.toggleBroadcast(true);
+
+		return API.v1.success();
+	},
 );

packages/gazzodown/src/Markup.spec.tsx

@@ -230,7 +230,7 @@ it('renders a code block', async () => {
 		</Suspense>,
 	);
 
-	await waitFor(() => expect(screen.getByRole('region')).toBeInTheDocument());
+	await waitFor(() => expect(screen.getByRole('region')).toBeInTheDocument(), { timeout: 5000 });
 
 	expect(screen.getByRole('region')).toHaveTextContent('```const foo = bar;```');
 });
@@ -250,7 +250,7 @@ it('renders a code block with language', async () => {
 		</Suspense>,
 	);
 
-	await waitFor(() => expect(screen.getByRole('region')).toBeInTheDocument());
+	await waitFor(() => expect(screen.getByRole('region')).toBeInTheDocument(), { timeout: 5000 });
 
 	expect(screen.getByRole('region')).toHaveTextContent('```const foo = bar;```');
 	expect(screen.getByRole('region').querySelector('.language-javascript')).toBeInTheDocument();
@@ -271,7 +271,7 @@ it('renders a Katex block', async () => {
 	);
 
 	// workaround for jest-dom's inability to handle MathML
-	await waitFor(() => expect(container.querySelector('math')).toBeTruthy());
+	await waitFor(() => expect(container.querySelector('math')).toBeTruthy(), { timeout: 5000 });
 	container.querySelector('math')?.remove();
 
 	expect(screen.getByRole('math', { name: 'x^2 + y^2 = z^2' })).toBeInTheDocument();