Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/meteor/app/lib/client/methods/sendMessage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,13 @@ Meteor.methods<ServerMethods>({

await onClientMessageReceived(message as IMessage).then((message) => {
Messages.state.store(message);
return clientCallbacks.run('afterSaveMessage', message, { room, user });
void clientCallbacks.run('afterSaveMessage', message, { room, user });

// Now that the message is stored, we can go ahead and mark as sent
Messages.state.update(
(record) => record._id === message._id && record.temp === true,
({ temp: _, ...record }) => record,
);
});
},
});
12 changes: 11 additions & 1 deletion apps/meteor/app/ui-utils/client/lib/LegacyRoomManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,17 @@ const openRoom = (typeName: string, record: OpenedRoom) => {
if (msg.t !== 'command') {
const subscription = Subscriptions.state.find(({ rid }) => rid === record.rid);
const isNew = !Messages.state.find((record) => record._id === msg._id && record.temp !== true);
({ _id: msg._id, temp: { $ne: true } });

// Measure and log message receive delay for messages
if (msg.ts) {
const receiveDelay = Date.now() - new Date(msg.ts).getTime();

// Log warning if delay is significant (>2 seconds)
if (receiveDelay > 2000) {
console.warn(`[Message Delivery] High delay detected: ${receiveDelay}ms. Possible network or backend issue.`);
}
}

await upsertMessage({ msg, subscription });
if (isNew) {
await clientCallbacks.run('streamNewMessage', msg);
Expand Down
9 changes: 8 additions & 1 deletion apps/meteor/client/stores/Messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,12 @@ import { createGlobalStore } from '../lib/cachedStores/createGlobalStore';
/** @deprecated prefer fetching data from the REST API, listening to changes via streamer events, and storing the state in a Tanstack Query */
export const Messages =
createGlobalStore(
createDocumentMapStore<IMessage & { ignored?: boolean; autoTranslateFetching?: boolean; autoTranslateShowInverse?: boolean }>(),
createDocumentMapStore<
IMessage & {
ignored?: boolean;
autoTranslateFetching?: boolean;
autoTranslateShowInverse?: boolean;
temp?: boolean;
}
>(),
);
Loading