Skip to content

fix: Variable shadowing preventing new visitor registration in livechat messages API #38040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 5 commits into from
Jan 13, 2026
+7 −2
Merged

fix: Variable shadowing preventing new visitor registration in livechat messages API #38040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea966f5
fix: ensure visitor variable is consistently defined in livechat mes…
harshjdhv Jan 1, 2026
93d7b47
Merge branch 'develop' into fix/livechat-messages-visitor-shadowing
KevLehman Jan 12, 2026
ea9685c
Create mean-eagles-complain.md
KevLehman Jan 12, 2026
dd5264f
Merge branch 'develop' into fix/livechat-messages-visitor-shadowing
kodiakhq[bot] Jan 12, 2026
481a23e
Merge branch 'develop' into fix/livechat-messages-visitor-shadowing
KevLehman Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mean-eagles-complain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes a variable shadowing issue preventing new visitor registration in `livechat/messages` API.
4 changes: 2 additions & 2 deletions apps/meteor/app/livechat/server/api/v1/message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ API.v1.addRoute(
async post() {
const visitorToken = this.bodyParams.visitor.token;

const visitor = await LivechatVisitors.getVisitorByToken(visitorToken, {});
let visitor = await LivechatVisitors.getVisitorByToken(visitorToken, {});
let rid: string;
if (visitor) {
const extraQuery = await callbacks.run('livechat.applyRoomRestrictions', {}, { userId: this.userId });
Expand All @@ -272,7 +272,7 @@ API.v1.addRoute(
guest.connectionData = normalizeHttpHeaderData(this.request.headers);
}

const visitor = await registerGuest(guest, { shouldConsiderIdleAgent: settings.get<boolean>('Livechat_enabled_when_agent_idle') });
visitor = await registerGuest(guest, { shouldConsiderIdleAgent: settings.get<boolean>('Livechat_enabled_when_agent_idle') });
if (!visitor) {
throw new Error('error-livechat-visitor-registration');
}
Expand Down
Loading