Skip to content

regression: Plus sign being added to external numbers #37968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tassoevan merged 2 commits into from
Dec 26, 2025
Merged

regression: Plus sign being added to external numbers #37968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26c095b
Stop adding "+" sign to numbers
gabriellsh Dec 24, 2025
ab0821d
update snapshots
gabriellsh Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-voip/src/components/CallHistoryExternalUser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const CallHistoryExternalUser = ({ number, showIcon = true }: CallHistoryExterna
<Icon name='phone' size={20} />
</Box>
)}
<Box>{number.startsWith('+') ? number : `+${number}`}</Box>
<Box>{number}</Box>
</Box>
);
};
Expand Down
2 changes: 1 addition & 1 deletion ...p/src/views/CallHistoryContextualbar/__snapshots__/CallHistoryContextualbar.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,7 @@ exports[`renders ExternalContact without crashing 1`] = `
<div
class="rcx-box rcx-box--full"
>
+1234567890
1234567890
</div>
</div>
</div>
Expand Down
Loading