Skip to content

chore!: migrate user names into existing Call History entries #37898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Dec 19, 2025
Merged

chore!: migrate user names into existing Call History entries #37898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/meteor/server/startup/migrations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,6 @@ import './v328';
import './v329';
import './v330';
import './v331';
import './v332';

export * from './xrun';
53 changes: 53 additions & 0 deletions apps/meteor/server/startup/migrations/v332.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
import { CallHistory, Users } from '@rocket.chat/models';

import { addMigration } from '../../lib/migrations';

addMigration({
version: 332,
name: 'Fill contact information on older call history entries',
async up() {
const cursor = CallHistory.col.aggregate([
{
$match: {
external: false,
contactId: { $exists: true },
contactName: { $exists: false },
contactUssername: { $exists: false },
},
Comment on lines +11 to +16
Copy link
Contributor

@coderabbitai coderabbitai bot Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical typo: contactUssername should be contactUsername.

Line 15 has a typo with double 's' in contactUssername. This breaks the filter logic—documents that already have contactUsername populated will still match because contactUssername (the typo) doesn't exist on any document. This will cause the migration to unnecessarily process and update records that should be skipped.

🔎 Proposed fix 
 			{
 				$match: {
 					external: false,
 					contactId: { $exists: true },
 					contactName: { $exists: false },
-					contactUssername: { $exists: false },
+					contactUsername: { $exists: false },
 				},
 			},
🤖 Prompt for AI Agents 
In apps/meteor/server/startup/migrations/v332.ts around lines 11 to 16, the
$match filter contains a typo "contactUssername" (double 's') which prevents
correct filtering; change that key to "contactUsername" so the query checks the
actual field, update any other occurrences of the misspelled field in this file,
and run the migration/dry-run to verify only documents missing contactUsername
are processed.

},

{
$lookup: {
from: Users.col.collectionName,
localField: 'contactId',
foreignField: '_id',
as: 'contactDetails',
},
},
{
$addFields: {
contactName: { $first: '$contactDetails.name' },
contactUsername: { $first: '$contactDetails.username' },
},
},
{
$project: {
contactName: 1,
contactUsername: 1,
},
},
{
$merge: {
into: CallHistory.col.collectionName,
on: '_id',
whenMatched: 'merge',
},
},
]);

// eslint-disable-next-line @typescript-eslint/no-unused-vars
for await (const _item of cursor) {
//
}
},
});
Loading