Skip to content

fix(http-router): resolve Hono method typing for Node 22 compatibility #37804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jaysinh146 wants to merge 4 commits into from
Closed

fix(http-router): resolve Hono method typing for Node 22 compatibility #37804

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
800d305
fix(http-router): resolve Hono method typing for Node 22 (Closes #37801)
Dec 14, 2025
b5a07c6
fix: replace any with strict Context type
Dec 14, 2025
c2dde15
refactor: use strict RouteMethod type definition
Dec 15, 2025
5d3b750
Merge branch 'develop' into fix/37801-node-22-typing
Jaysinh146 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/http-router/src/Router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export class Router<
const [middlewares, action] = splitArray<MiddlewareHandler, TActionCallback>(actions);
const convertedAction = this.convertActionToHandler(action);

this.innerRouter[method.toLowerCase() as Lowercase<Method>](`/${subpath}`.replace('//', '/'), ...middlewares, async (c) => {
(this.innerRouter[method.toLowerCase() as keyof typeof this.innerRouter] as Function)(`/${subpath}`.replace('//', '/'), ...middlewares, async (c: any) => {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Comment thread
Jaysinh146 marked this conversation as resolved.
Outdated
const { req, res } = c;

const queryParams = this.parseQueryParams(req);
Expand Down