Skip to content

chore(tracing): Review build configuration #37609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Nov 25, 2025
Merged

chore(tracing): Review build configuration #37609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/tracing/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"extends": ["@rocket.chat/eslint-config"],
"ignorePatterns": ["**/dist"]
"ignorePatterns": ["dist"]
}
32 changes: 16 additions & 16 deletions packages/tracing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,31 @@
"name": "@rocket.chat/tracing",
"version": "0.0.1",
"private": true,
"devDependencies": {
"@types/jest": "~30.0.0",
"eslint": "~8.45.0",
"jest": "~30.2.0",
"ts-jest": "~29.4.5",
"typescript": "~5.9.3"
},
"scripts": {
"lint": "eslint --ext .js,.jsx,.ts,.tsx .",
"lint:fix": "eslint --ext .js,.jsx,.ts,.tsx . --fix",
"testunit": "jest --passWithNoTests",
"dev": "tsc --watch --preserveWatchOutput",
"build": "rm -rf dist && tsc"
},
"main": "./dist/index.js",
"typings": "./dist/index.d.ts",
"files": [
"/dist"
],
"volta": {
"extends": "../../package.json"
"scripts": {
"build": "rm -rf dist && tsc",
"dev": "tsc --watch --preserveWatchOutput",
"lint": "eslint --ext .js,.jsx,.ts,.tsx .",
"lint:fix": "eslint --ext .js,.jsx,.ts,.tsx . --fix",
"testunit": "jest --passWithNoTests"
},
"dependencies": {
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/exporter-trace-otlp-grpc": "^0.54.2",
"@opentelemetry/sdk-node": "^0.54.2"
},
Comment on lines 17 to +21
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

@opentelemetry/api 1.9.0 npm package version

<web_search_result>
Yes — @opentelemetry/api version 1.9.0 is published on npm (listed as the package's current/latest release). [1][2]

Sources:
[1] npm organization package listing (opentelemetry) — shows @opentelemetry/api published version 1.9.0.
[2] jsDelivr / package page — @opentelemetry/api version 1.9.0.
</web_search_result>

@opentelemetry/sdk-node 0.54.2 @opentelemetry/exporter-trace-otlp-grpc 0.54.2 compatibility

<web_search_result>
Short answer: Yes — @opentelemetry/[email protected] and @opentelemetry/[email protected] are compatible and intended to be used together (OpenTelemetry JS packages with the same release line are published to work together). See the exporter docs and the SDK guidance that exporters must be installed alongside @opentelemetry/sdk-node. [1][2][3]

References

  • Exporter docs (exporter-trace-otlp-grpc). [1]
  • SDK Node docs (note that exporters are installed alongside @opentelemetry/sdk-node). [2]
  • npm package listing for 0.54.2 showing that 0.54.x packages were published as a matching set. [3]
    </web_search_result>

@opentelemetry/api 1.9.0 @opentelemetry/sdk-node 0.54.2 version compatibility

<web_search_result>
Short answer: No — @opentelemetry/api 1.9.0 is not compatible with @opentelemetry/sdk-node 0.54.2. The official compatibility matrix pairs experimental SDK versions 0.54.x with API ~1.27.x, while API 1.9.x maps to much older experimental SDKs (≈0.35.x). See the OpenTelemetry JS compatibility table and the @opentelemetry/api 1.9.0 package info. [1][2]

Sources:

  • OpenTelemetry JS package compatibility table. [1]
  • @opentelemetry/api 1.9.0 package entry. [2]

References:
[1] https://github.com/open-telemetry/opentelemetry-js — Package Version Compatibility.
[2] https://jsr.io/%40opentelemetry/api — @opentelemetry/[email protected] package page.
</web_search_result>

Update OpenTelemetry API version for SDK compatibility.

The @opentelemetry/api version 1.9.0 is incompatible with @opentelemetry/sdk-node 0.54.2. According to the OpenTelemetry JS compatibility matrix, SDK 0.54.x requires API ~1.27.x; API 1.9.x corresponds to much older SDK versions (~0.35.x). Update @opentelemetry/api to ^1.27.0 or later to align with the 0.54.2 SDK and exporter versions.

	"dependencies": {
		"@opentelemetry/api": "^1.27.0",
		"@opentelemetry/exporter-trace-otlp-grpc": "^0.54.2",
		"@opentelemetry/sdk-node": "^0.54.2"
	},
🤖 Prompt for AI Agents 
In packages/tracing/package.json around lines 17 to 21 the @opentelemetry/api
dependency is pinned to ^1.9.0 which is incompatible with
@opentelemetry/sdk-node ^0.54.2; update the @opentelemetry/api entry to ^1.27.0
(or a compatible >=1.27.x) to match the SDK/exporter versions, then run your
package manager (npm/yarn/pnpm) to update the lockfile and verify the project
builds/tests pass.

"devDependencies": {
"@types/jest": "~30.0.0",
"eslint": "~8.45.0",
"jest": "~30.2.0",
"ts-jest": "~29.4.5",
"typescript": "~5.9.3"
},
Comment on lines +22 to +28
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Invalid devDependencies versions.

The specified versions appear to be invalid:

  • jest: ~30.2.0 — Jest 30.x does not exist; the latest stable version is 29.x
  • @types/jest: ~30.0.0 — @types/jest 30.x does not exist and should match the Jest version used
  • Other versions may also need verification for accuracy

Please verify and correct these versions. Run the following script to check what versions are actually available:

#!/bin/bash
# Description: Check available versions of dev dependencies

npm view jest versions --json | tail -20
npm view @types/jest versions --json | tail -20
npm view eslint versions --json | tail -20
npm view typescript versions --json | tail -20
npm view ts-jest versions --json | tail -20
🤖 Prompt for AI Agents 
In packages/tracing/package.json around lines 22-28, the devDependencies list
contains invalid/incorrect versions (e.g., jest ~30.2.0 and @types/jest
~30.0.0). Verify the actual available stable versions (use npm view/npm info as
suggested), then update package.json to use a valid Jest 29.x version and the
matching @types/jest 29.x, ensure ts-jest and typescript versions are compatible
with that Jest release, save the corrected versions in package.json, run npm
install to update lockfile, and run the test suite to confirm everything works.

"volta": {
"extends": "../../package.json"
}
}
Loading