Skip to content

chore(ui-avatar): Review build configuration #37608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Nov 25, 2025
Merged

chore(ui-avatar): Review build configuration #37608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/ui-avatar/.eslintignore
View file
Open in desktop

This file was deleted.

65 changes: 2 additions & 63 deletions packages/ui-avatar/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,65 +1,4 @@
{
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/eslint-recommended",
"@rocket.chat/eslint-config/original",
"@rocket.chat/eslint-config/react",
"prettier",
"plugin:anti-trojan-source/recommended",
"plugin:react/jsx-runtime",
"plugin:storybook/recommended"
],
"parser": "@typescript-eslint/parser",
"plugins": ["@typescript-eslint", "prettier"],
"rules": {
"func-call-spacing": "off",
"import/named": "error",
"import/order": [
"error",
{
"newlines-between": "always",
"groups": ["builtin", "external", "internal", ["parent", "sibling", "index"]],
"alphabetize": {
"order": "asc"
}
}
],
"indent": "off",
"jsx-quotes": ["error", "prefer-single"],
"new-cap": ["error"],
"no-extra-parens": "off",
"no-spaced-func": "off",
"no-undef": "off",
"no-unused-vars": "off",
"no-useless-constructor": "off",
"no-use-before-define": "off",
"prefer-arrow-callback": ["error", { "allowNamedFunctions": true }],
"prettier/prettier": 2
},
"settings": {
"import/resolver": {
"node": {
"extensions": [".js", ".ts", ".tsx"]
}
}
},
"ignorePatterns": ["**/dist"],
"overrides": [
{
"files": ["*.ts", "*.tsx"],
"rules": {
"@typescript-eslint/ban-ts-ignore": "off",
"@typescript-eslint/indent": "off",
"@typescript-eslint/no-extra-parens": "off",
"@typescript-eslint/no-explicit-any": "off",
"@typescript-eslint/no-unused-vars": [
"error",
{
"argsIgnorePattern": "^_"
}
],
"@typescript-eslint/prefer-optional-chain": "warn"
}
}
]
"extends": ["@rocket.chat/eslint-config", "@rocket.chat/eslint-config/react"],
"ignorePatterns": ["dist", "storybook-static", "!.storybook"]
}
25 changes: 12 additions & 13 deletions packages/ui-avatar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,19 @@
"name": "@rocket.chat/ui-avatar",
"version": "20.0.0",
"private": true,
"main": "./dist/index.js",
"typings": "./dist/index.d.ts",
"files": [
"/dist"
],
"scripts": {
"build": "rm -rf dist && tsc -p tsconfig.build.json",
"dev": "tsc -p tsconfig.build.json --watch --preserveWatchOutput",
"lint": "eslint --ext .js,.jsx,.ts,.tsx .",
"lint:fix": "eslint --ext .js,.jsx,.ts,.tsx . --fix",
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"devDependencies": {
"@babel/core": "~7.28.5",
"@rocket.chat/core-typings": "workspace:~",
"@rocket.chat/emitter": "~0.31.25",
"@rocket.chat/fuselage": "~0.68.1",
Expand All @@ -23,18 +34,6 @@
"react-virtuoso": "^4.12.0",
"typescript": "~5.9.3"
},
"scripts": {
"lint": "eslint --ext .js,.jsx,.ts,.tsx .",
"lint:fix": "eslint --ext .js,.jsx,.ts,.tsx . --fix",
"build": "rm -rf dist && tsc -p tsconfig-build.json",
"typecheck": "tsc -p tsconfig.json --noEmit",
"dev": "tsc -p tsconfig-build.json --watch --preserveWatchOutput"
},
"main": "./dist/index.js",
"typings": "./dist/index.d.ts",
"files": [
"/dist"
],
"peerDependencies": {
"@rocket.chat/fuselage": "*",
"@rocket.chat/ui-contexts": "workspace:^",
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-avatar/src/components/AppAvatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { ReactElement } from 'react';

import BaseAvatar, { BaseAvatarProps } from './BaseAvatar';
import type { BaseAvatarProps } from './BaseAvatar';
import BaseAvatar from './BaseAvatar';

type AppAvatarProps = Pick<BaseAvatarProps, 'size'> & {
iconFileContent: string;
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-avatar/src/components/RoomAvatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import { useRoomAvatarPath } from '@rocket.chat/ui-contexts';
import type { ReactElement } from 'react';
import { memo } from 'react';

import Avatar, { BaseAvatarProps } from './BaseAvatar';
import type { BaseAvatarProps } from './BaseAvatar';
import Avatar from './BaseAvatar';

type RoomAvatarProps = Pick<BaseAvatarProps, 'size'> & {
url?: string;
Expand Down
0 packages/ui-avatar/tsconfig-build.json → packages/ui-avatar/tsconfig.build.json
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10266,7 +10266,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "@rocket.chat/ui-avatar@workspace:packages/ui-avatar"
dependencies:
"@babel/core": "npm:~7.28.5"
"@rocket.chat/core-typings": "workspace:~"
"@rocket.chat/emitter": "npm:~0.31.25"
"@rocket.chat/fuselage": "npm:~0.68.1"
Expand Down
Loading